Re: [PATCH] staging : Comedi : comedi_fops : Fixed the return error code

Re: [PATCH] staging : Comedi : comedi_fops : Fixed the return error code

[Ian Abbott]

On 21/06/15 11:01, Santosh wrote:
> This patch fixes the checkpatch.pl warning:
>
> WARNING: ENOSYS means 'invalid syscall nr' and nothing else
>
> Regards,
>
> Santosh Pai
>
>
> 0001-staging-Comedi-comedi_fops-Fixed-the-return-error-co.patch

Greg doesn't usually take patches in attachments.

>  From 502464417255edb52a1db71146e2f33e67df87ce Mon Sep 17 00:00:00 2001
> From: sanpai<santhosh.pai88@yahoo.com>
> Date: Sun, 21 Jun 2015 15:05:00 +0530
> Subject: [PATCH] staging : Comedi : comedi_fops : Fixed the return error code
>
>      try_module_get fails when the reference count of the module is not
>      allowed to be incremented ,and hence -EPERM is returned.
>
> Signed-off-by: sanpai<santhosh.pai88@yahoo.com>
> ---
>   drivers/staging/comedi/comedi_fops.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
> index 985d94b..d6a37e9 100644
> --- a/drivers/staging/comedi/comedi_fops.c
> +++ b/drivers/staging/comedi/comedi_fops.c
> @@ -2606,7 +2606,7 @@ static int comedi_open(struct inode *inode, struct file *file)
>   	}
>   	if (dev->attached && dev->use_count == 0) {
>   		if (!try_module_get(dev->driver->module)) {
> -			rc = -ENOSYS;
> +			rc = -EPERM;

Why -EPERM?  I think either -ENODEV or -ENXIO would be better.

>   			goto out;
>   		}
>   		if (dev->open) {
> -- 1.7.9.5
>


-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] staging : Comedi : comedi_fops : Fixed the return error code

[Sudip Mukherjee]

On Mon, Jun 22, 2015 at 10:37:43AM +0100, Ian Abbott wrote:
> On 21/06/15 11:01, Santosh wrote:
> >This patch fixes the checkpatch.pl warning:
> >
> >WARNING: ENOSYS means 'invalid syscall nr' and nothing else
> >
> >Regards,
> >
> >Santosh Pai
> >
> >
> >0001-staging-Comedi-comedi_fops-Fixed-the-return-error-co.patch
> 
> Greg doesn't usually take patches in attachments.
> 
> > From 502464417255edb52a1db71146e2f33e67df87ce Mon Sep 17 00:00:00 2001
> >From: sanpai<santhosh.pai88@yahoo.com>
> >Date: Sun, 21 Jun 2015 15:05:00 +0530
> >Subject: [PATCH] staging : Comedi : comedi_fops : Fixed the return error code
> >
> >     try_module_get fails when the reference count of the module is not
> >     allowed to be incremented ,and hence -EPERM is returned.
> >
> >Signed-off-by: sanpai<santhosh.pai88@yahoo.com>
And your Signed-off-by name is not matching with your email From: header
name. Please use your real name in both places. I don't think "sanpai" is
your real name.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

Re: Subject: [PATCH 1/2] staging : Comedi : comedi_fops : Fixed the return error, code

[Ian Abbott]

On 29/06/15 10:15, Ian Abbott wrote:
> On 27/06/15 06:36, Santhosh Pai wrote:
>>
>>  From 9ea09e194d6ccdd0b229b408df1c86b43b1fdd7d Mon Sep 17 00:00:00 2001
>> From: santhosh pai <santhosh.pai88@yahoo.com>
>> Date: Mon, 22 Jun 2015 23:26:33 +0530
>> Subject: [PATCH 2/2] staging : Comedi : comedi_fops : Fixed the return
>> error
>>   code
>>
>>    try_module_get fails when the reference count of the module is not
>>    allowed to be incremented ,and hence -ENXIO is returned indicating
>>    no device or address.
>>
>> Signed-off-by: santhosh pai <santhosh.pai88@yahoo.com>
>> ---
>>   drivers/staging/comedi/comedi_fops.c |    2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/comedi/comedi_fops.c
>> b/drivers/staging/comedi/comedi_fops.c
>> index d6a37e9..1ab443c 100644
>> --- a/drivers/staging/comedi/comedi_fops.c
>> +++ b/drivers/staging/comedi/comedi_fops.c
>> @@ -2606,7 +2606,7 @@ static int comedi_open(struct inode *inode,
>> struct file *file)
>>       }
>>       if (dev->attached && dev->use_count == 0) {
>>           if (!try_module_get(dev->driver->module)) {
>> -            rc = -EPERM;
>> +            rc = -ENXIO;
>>               goto out;
>>           }
>>           if (dev->open) {
>>
>
> The patch itself is okay, but all the stuff around the patch is a bit
> weird, such as:
>
> 1. all those email headers in the commit message
> 2. useless indentation in the commit message
> 3. subject line in commit message says "PATCH 2/2", but email subject
> line says "PATCH 1/2"
> 4. stray comma in email subject line
> 5. spaces before colon in subject lines

Actually, the patch doesn't apply, because it's on top of your other 
patch that changed -ENOSYS to -EPERM.

>
> This is taking too long, so I'll post a cleaned-up version.
>

I'll combine your two changes to the error return value into a single patch.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-

[PATCH] staging: Comedi: comedi_fops: Fixed the return error code

[Ian Abbott]

From: Santhosh Pai <santhosh.pai88@yahoo.com>

From: Santhosh Pai <santhosh.pai88@yahoo.com>

This patch fixes the checkpatch.pl warning:

WARNING: ENOSYS means 'invalid syscall nr' and nothing else

try_module_get fails when the reference count of the module is not
allowed to be incremented ,and hence -ENXIO is returned indicating
no device or address.

[IA - combined two of santhosh's changes to the error return value!]

Signed-off-by: santhosh pai <santhosh.pai88@yahoo.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
---
 drivers/staging/comedi/comedi_fops.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
index 985d94b..1ab443c 100644
--- a/drivers/staging/comedi/comedi_fops.c
+++ b/drivers/staging/comedi/comedi_fops.c
@@ -2606,7 +2606,7 @@ static int comedi_open(struct inode *inode, struct file *file)
 	}
 	if (dev->attached && dev->use_count == 0) {
 		if (!try_module_get(dev->driver->module)) {
-			rc = -ENOSYS;
+			rc = -ENXIO;
 			goto out;
 		}
 		if (dev->open) {
-- 
2.1.4

Re: [PATCH] staging: Comedi: comedi_fops: Fixed the return error code

[Ian Abbott]

On 29/06/15 10:41, Ian Abbott wrote:
> From: Santhosh Pai <santhosh.pai88@yahoo.com>
>
> From: Santhosh Pai <santhosh.pai88@yahoo.com>

Oops.  I managed to screw it up as well.  I'll repost it.


-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-

[PATCH] staging: Comedi: comedi_fops: Fixed the return error code

[Ian Abbott]

From: Santhosh Pai <santhosh.pai88@yahoo.com>

This patch fixes the checkpatch.pl warning:

WARNING: ENOSYS means 'invalid syscall nr' and nothing else

try_module_get fails when the reference count of the module is not
allowed to be incremented ,and hence -ENXIO is returned indicating
no device or address.

[IA - combined two of santhosh's changes to the error return value!]

Signed-off-by: santhosh pai <santhosh.pai88@yahoo.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
---
 drivers/staging/comedi/comedi_fops.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
index 985d94b..1ab443c 100644
--- a/drivers/staging/comedi/comedi_fops.c
+++ b/drivers/staging/comedi/comedi_fops.c
@@ -2606,7 +2606,7 @@ static int comedi_open(struct inode *inode, struct file *file)
 	}
 	if (dev->attached && dev->use_count == 0) {
 		if (!try_module_get(dev->driver->module)) {
-			rc = -ENOSYS;
+			rc = -ENXIO;
 			goto out;
 		}
 		if (dev->open) {
-- 
2.1.4