From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Luis de Bethencourt <luis@debethencourt.com>
Cc: linux-kernel@vger.kernel.org, Ian Abbott <abbotti@mev.co.uk>,
H Hartley Sweeten <hsweeten@visionengravers.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jaime Arrocha <jarr@kerneldev.net>
Subject: Re: [PATCH] staging: comedi: coding style fixes
Date: Mon, 22 Jun 2015 17:09:40 +0530 [thread overview]
Message-ID: <20150622113940.GE3355@sudip-PC> (raw)
In-Reply-To: <20150621202530.GA20452@turing>
On Sun, Jun 21, 2015 at 09:25:30PM +0100, Luis de Bethencourt wrote:
> Warnings found by checkpatch.pl
>
> WARNING: please, no space before tabs
> /drivers/staging/comedi/drivers/das16m1.c:83
> + 404-407 ^I8254$
>
> WARNING: line over 80 characters
> /drivers/staging/comedi/drivers/das16m1.c:414
> + if (devpriv->adc_count == 0 && hw_counter == devpriv->initial_hw_count) {
That is two different type of changes. Please break them into separate
patches.
regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at http://www.tux.org/lkml/
prev parent reply other threads:[~2015-06-22 11:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-21 20:25 [PATCH] staging: comedi: coding style fixes Luis de Bethencourt
2015-06-22 11:39 ` Sudip Mukherjee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150622113940.GE3355@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=abbotti@mev.co.uk \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=jarr@kerneldev.net \
--cc=linux-kernel@vger.kernel.org \
--cc=luis@debethencourt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox