From: Luis de Bethencourt <luis@debethencourt.com>
To: Ian Abbott <abbotti@mev.co.uk>
Cc: linux-kernel@vger.kernel.org,
H Hartley Sweeten <hsweeten@visionengravers.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jaime Arrocha <jarr@kerneldev.net>
Subject: Re: [PATCH v2 1/2] staging: comedi: no space before tabs
Date: Mon, 22 Jun 2015 15:12:09 +0200 [thread overview]
Message-ID: <20150622131209.GA25517@goodgumbo.baconseed.org> (raw)
In-Reply-To: <55880227.8000705@mev.co.uk>
On Mon, Jun 22, 2015 at 01:40:07PM +0100, Ian Abbott wrote:
> On 22/06/15 13:31, Luis de Bethencourt wrote:
> >Warning found by checkpatch.pl
> >WARNING: please, no space before tabs
> >/drivers/staging/comedi/drivers/das16m1.c:83
> >+ 404-407 ^I8254$
> >
> >Signed-off-by: Luis de Bethencourt <luis@debethencourt.com>
> >---
> > drivers/staging/comedi/drivers/das16m1.c | 24 ++++++++++++------------
> > 1 file changed, 12 insertions(+), 12 deletions(-)
>
> Like for your "Author string" patch for das08_cs.c, it would be nice
> to mention the module name in the subject line in this patch and in
> patch 2 of the series, especially as these changes are for a
> specific module, not the whole of comedi.
>
Makes sense. I should've gone ahead and done it sooner. Fixed now.
Thanks for the review,
Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at http://www.tux.org/lkml/
prev parent reply other threads:[~2015-06-22 13:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-22 12:31 [PATCH v2 1/2] staging: comedi: no space before tabs Luis de Bethencourt
2015-06-22 12:40 ` Ian Abbott
2015-06-22 13:12 ` Luis de Bethencourt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150622131209.GA25517@goodgumbo.baconseed.org \
--to=luis@debethencourt.com \
--cc=abbotti@mev.co.uk \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=jarr@kerneldev.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox