From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752416AbbFVOpI (ORCPT ); Mon, 22 Jun 2015 10:45:08 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:25544 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751217AbbFVOot (ORCPT ); Mon, 22 Jun 2015 10:44:49 -0400 Date: Mon, 22 Jun 2015 17:44:39 +0300 From: Dan Carpenter To: Sudip Mukherjee Cc: Jakub Sitnicki , devel@driverdev.osuosl.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Larry Finger Subject: Re: [PATCH] staging: rtl8188eu: kill unused hal_data_8188e::fw_ractrl flag Message-ID: <20150622144439.GZ28762@mwanda> References: <1434609119-19680-1-git-send-email-jsitnicki@gmail.com> <20150618083018.GD11984@sudip-PC> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150618083018.GD11984@sudip-PC> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 18, 2015 at 02:00:18PM +0530, Sudip Mukherjee wrote: > On Thu, Jun 18, 2015 at 08:31:59AM +0200, Jakub Sitnicki wrote: > > --- a/drivers/staging/rtl8188eu/hal/odm.c > > +++ b/drivers/staging/rtl8188eu/hal/odm.c > > @@ -1170,13 +1170,10 @@ void odm_RSSIMonitorCheckCE(struct odm_dm_struct *pDM_Odm) > > } > > > > for (i = 0; i < sta_cnt; i++) { > > - if (PWDB_rssi[i] != (0)) { > > - if (pHalData->fw_ractrl) { > > - /* Report every sta's RSSI to FW */ > > - } else { > > - ODM_RA_SetRSSI_8188E( > > - &(pHalData->odmpriv), (PWDB_rssi[i]&0xFF), (u8)((PWDB_rssi[i]>>16) & 0xFF)); > > - } > > + if (PWDB_rssi[i] != 0) { > > + ODM_RA_SetRSSI_8188E(&pHalData->odmpriv, > > + PWDB_rssi[i] & 0xFF, > > + (PWDB_rssi[i] >> 16) & 0xFF); > and you are also removing an extra unneeded () and a typecast. These are minor related changes (on the same line). It could have been mentioned in the changelog but if not then it's not really worth worrying about because it's so small. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/