Re: [v2,3/3] watchdog: max63xx: add heartbeat to platform data

[Guenter Roeck <linux@roeck-us.net>]

Hi Vivien,

On Wed, Jun 17, 2015 at 06:59:00PM -0400, Vivien Didelot wrote:
> Actually, there is no way but the module parameter to set the desired
> heartbeat. This patch allows a platform code to set it in the device
> platform data. This is convenient for platforms and built-in drivers.
> 
> To do so, initialize heartbeat to zero to allow the module parameter to
> take precedence over the platform setting. If not set, it will still
> default to DEFAULT_HEARTBEAT.
> 

I think that warrants a bit of discussion. Is the chip used on an
x86 system (no devicetree), and is there reason to believe that the
default watchdog timeout is not good enough until the watchdog application
starts and can configure it to a different value ?

This is also a bit more complicated since gpio pin 0 can be a valid gpio
pin number, so you'd have to explicitly state "don't use gpio" in the
platform data.

Thanks,
Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/