From: Dan Carpenter <dan.carpenter@oracle.com>
To: Juston Li <juston.h.li@gmail.com>
Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: sm750fb: use tabs for indentation
Date: Mon, 22 Jun 2015 20:46:02 +0300 [thread overview]
Message-ID: <20150622174601.GF28762@mwanda> (raw)
In-Reply-To: <1434761450-15722-1-git-send-email-juston.h.li@gmail.com>
On Fri, Jun 19, 2015 at 05:50:50PM -0700, Juston Li wrote:
> void sii164ClearInterrupt(void)
> {
> - unsigned char detectReg;
> + unsigned char detectReg;
>
> - /* Clear the MDI interrupt */
> - detectReg = i2cReadReg(SII164_I2C_ADDRESS, SII164_DETECT);
> - i2cWriteReg(SII164_I2C_ADDRESS, SII164_DETECT, detectReg | SII164_DETECT_MONITOR_STATE_CLEAR);
The patch accidentally deletes this write.
> + /* Clear the MDI interrupt */
> + detectReg = i2cReadReg(SII164_I2C_ADDRESS, SII164_DETECT);
> }
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2015-06-22 17:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-20 0:50 [PATCH] staging: sm750fb: use tabs for indentation Juston Li
2015-06-22 17:46 ` Dan Carpenter [this message]
2015-06-22 18:30 ` Juston Li
2015-06-24 9:28 ` Dan Carpenter
2015-06-24 16:29 ` Juston Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150622174601.GF28762@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=juston.h.li@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox