From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932238AbbFWHLA (ORCPT ); Tue, 23 Jun 2015 03:11:00 -0400 Received: from mail-wi0-f182.google.com ([209.85.212.182]:32888 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752328AbbFWHKu (ORCPT ); Tue, 23 Jun 2015 03:10:50 -0400 Date: Tue, 23 Jun 2015 08:10:45 +0100 From: Lee Jones To: Viresh Kumar Cc: rob.herring@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@stlinux.com, rjw@rjwysocki.net, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, ajitpal.singh@st.com Subject: Re: [PATCH 4/8] ARM: STi: STiH407: Provide a node for CPUFreq Message-ID: <20150623071045.GC3245@x1> References: <1434987837-24212-1-git-send-email-lee.jones@linaro.org> <1434987837-24212-5-git-send-email-lee.jones@linaro.org> <20150623021622.GA16776@linux> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150623021622.GA16776@linux> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 23 Jun 2015, Viresh Kumar wrote: > [Ccing Rob] Rob is already Cc'ed. > On 22-06-15, 16:43, Lee Jones wrote: > > Signed-off-by: Lee Jones > > --- > > arch/arm/boot/dts/stih407-family.dtsi | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi > > index f48767e..f57fd83 100644 > > --- a/arch/arm/boot/dts/stih407-family.dtsi > > +++ b/arch/arm/boot/dts/stih407-family.dtsi > > @@ -98,6 +98,11 @@ > > ranges; > > compatible = "simple-bus"; > > > > + cpufreq { > > + compatible = "st,stih407-cpufreq"; > > + st,syscfg = <&syscfg_core 0x8e0>; > > + }; > > These virtual nodes aren't allowed in DT and you have added them > before the bindings patch :). This isn't a virtual node, but you bring up a good point. The compatible string should also contain "syscon". -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/