From: Dan Carpenter <dan.carpenter@oracle.com>
To: Greg Donald <gdonald@gmail.com>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
devel@driverdev.osuosl.org,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
Cristina Opriceana <cristina.opriceana@gmail.com>
Subject: Re: [PATCH] drivers: staging: rtl8192u: Fix "space required before the open parenthesis '('" errors
Date: Tue, 23 Jun 2015 11:01:34 +0300 [thread overview]
Message-ID: <20150623080134.GH28762@mwanda> (raw)
In-Reply-To: <CAO+WgCZFGiD1REh+mkPgQmK0OecAaa42m+LENNAU3L3mD8fxLg@mail.gmail.com>
On Mon, Jun 22, 2015 at 06:25:11AM -0500, Greg Donald wrote:
> Umm.. you have to fix more than one error if there's more than one
> error on or very near the same line you are already fixing, else
> checkpatch.pl complains that your patch has errors. Not to mention
> Greg KH has never complained:
>
> http://git.kernel.org/cgit/linux/kernel/git/gregkh/staging.git/log/?qt=grep&q=gdonald
>
Actually, Greg complains about these all the time.
And here is a useless URL that you can look at: http://slashdot.org
I'm sure it supports my argument.
But seriously, he does complain about these.
regards,
dan carpenter
next prev parent reply other threads:[~2015-06-23 8:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-20 20:56 [PATCH] drivers: staging: rtl8192u: Fix "space required before the open parenthesis '('" errors Greg Donald
2015-06-22 11:10 ` Sudip Mukherjee
2015-06-22 11:25 ` Greg Donald
2015-06-23 8:01 ` Dan Carpenter [this message]
2015-06-23 22:52 ` Greg Donald
[not found] ` <1435100814.2504.23.camel@perches.com>
[not found] ` <20150624093722.GK30834@mwanda>
[not found] ` <1435156387.9377.3.camel@perches.com>
[not found] ` <20150624144325.GL30834@mwanda>
2015-06-24 14:55 ` [PATCH -next] checkpatch: Fix long line messages about patch context Joe Perches
2015-07-15 2:42 ` [PATCH] drivers: staging: rtl8192u: Fix "space required before the open parenthesis '('" errors Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150623080134.GH28762@mwanda \
--to=dan.carpenter@oracle.com \
--cc=cristina.opriceana@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gdonald@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hamohammed.sa@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox