From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932608AbbFWIB4 (ORCPT ); Tue, 23 Jun 2015 04:01:56 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:30857 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752062AbbFWIBt (ORCPT ); Tue, 23 Jun 2015 04:01:49 -0400 Date: Tue, 23 Jun 2015 11:01:34 +0300 From: Dan Carpenter To: Greg Donald Cc: Sudip Mukherjee , devel@driverdev.osuosl.org, Haneen Mohammed , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Cristina Opriceana Subject: Re: [PATCH] drivers: staging: rtl8192u: Fix "space required before the open parenthesis '('" errors Message-ID: <20150623080134.GH28762@mwanda> References: <1434833768-8336-1-git-send-email-gdonald@gmail.com> <20150622111014.GB3355@sudip-PC> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 22, 2015 at 06:25:11AM -0500, Greg Donald wrote: > Umm.. you have to fix more than one error if there's more than one > error on or very near the same line you are already fixing, else > checkpatch.pl complains that your patch has errors. Not to mention > Greg KH has never complained: > > http://git.kernel.org/cgit/linux/kernel/git/gregkh/staging.git/log/?qt=grep&q=gdonald > Actually, Greg complains about these all the time. And here is a useless URL that you can look at: http://slashdot.org I'm sure it supports my argument. But seriously, he does complain about these. regards, dan carpenter