From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932139AbbFWI4M (ORCPT ); Tue, 23 Jun 2015 04:56:12 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:51410 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751692AbbFWI4D (ORCPT ); Tue, 23 Jun 2015 04:56:03 -0400 Date: Tue, 23 Jun 2015 11:55:48 +0300 From: Dan Carpenter To: Sudip Mukherjee Cc: Isaac Assegai , devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, teddy.wang@siliconmotion.com Subject: Re: [PATCH 6/8] Staging: sm750fb: ddk750_sii164.c: Place braces on previous lines Message-ID: <20150623085548.GM28762@mwanda> References: <1434743301-14774-1-git-send-email-isaac.a.travers@gmail.com> <1434743301-14774-7-git-send-email-isaac.a.travers@gmail.com> <20150620072402.GA15195@sudip-PC> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150620072402.GA15195@sudip-PC> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jun 20, 2015 at 12:54:02PM +0530, Sudip Mukherjee wrote: > On Fri, Jun 19, 2015 at 12:48:19PM -0700, Isaac Assegai wrote: > > Place braces on previous lines in ddk750_sii164.c to > > rectify the following checkpatch errors: > > ERROR: that open brace { should be on the previous line > > > > Signed-off-by: Isaac Assegai > > --- > > drivers/staging/sm750fb/ddk750_sii164.c | 16 +++++----------- > > 1 file changed, 5 insertions(+), 11 deletions(-) > > > > diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c > > index 7f58fbe..64d4291 100644 > > --- a/drivers/staging/sm750fb/ddk750_sii164.c > > +++ b/drivers/staging/sm750fb/ddk750_sii164.c > > @@ -136,8 +136,7 @@ long sii164InitChip( > > #endif > > > > /* Check if SII164 Chip exists */ > > - if ((sii164GetVendorID() == SII164_VENDOR_ID) && (sii164GetDeviceID() == SII164_DEVICE_ID)) > > - { > > + if ((sii164GetVendorID() == SII164_VENDOR_ID) && (sii164GetDeviceID() == SII164_DEVICE_ID) { > ^^^^ > you have not build tested it :( > In function ‘sii164InitChip’: > error: expected ‘)’ before ‘{’ token > I never get Isaac's emails. I think gmail is still sending them to the Spam folder? I searched my spam folder and don't see them though... regards, dan carpenter