From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: ChengYi He <chengyihetaipei@gmail.com>
Cc: Felipe Balbi <balbi@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: ulpi: call put_device if device_register fails
Date: Tue, 23 Jun 2015 13:57:38 +0300 [thread overview]
Message-ID: <20150623105738.GD1296@kuha.fi.intel.com> (raw)
In-Reply-To: <20150618171236.GA18007@chengyihe-ThinkCentre-M82>
On Fri, Jun 19, 2015 at 01:12:36AM +0800, ChengYi He wrote:
> put_device is required to release the last reference to the device.
>
> Signed-off-by: ChengYi He <chengyihetaipei@gmail.com>
> ---
> drivers/usb/common/ulpi.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/common/ulpi.c b/drivers/usb/common/ulpi.c
> index 0e6f968..bd25bdb 100644
> --- a/drivers/usb/common/ulpi.c
> +++ b/drivers/usb/common/ulpi.c
> @@ -184,8 +184,10 @@ static int ulpi_register(struct device *dev, struct ulpi *ulpi)
> request_module("ulpi:v%04xp%04x", ulpi->id.vendor, ulpi->id.product);
>
> ret = device_register(&ulpi->dev);
> - if (ret)
> + if (ret) {
> + put_device(&ulpi->dev);
If device_register returns failure, put_device has already been
called. Check device_add in drivers/base/core.c.
Thanks,
--
heikki
next prev parent reply other threads:[~2015-06-23 10:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-18 17:12 [PATCH] usb: ulpi: call put_device if device_register fails ChengYi He
2015-06-23 10:57 ` Heikki Krogerus [this message]
2015-07-22 21:39 ` Greg Kroah-Hartman
2015-07-23 2:04 ` Felipe Balbi
2015-07-23 3:14 ` Greg Kroah-Hartman
2015-07-23 5:02 ` Felipe Balbi
2015-07-23 18:00 ` Greg Kroah-Hartman
2015-07-23 20:08 ` Felipe Balbi
2015-07-23 20:46 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150623105738.GD1296@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=balbi@ti.com \
--cc=chengyihetaipei@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox