From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754783AbbFWSDt (ORCPT <rfc822;w@1wt.eu>);
	Tue, 23 Jun 2015 14:03:49 -0400
Received: from mx1.redhat.com ([209.132.183.28]:40274 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754766AbbFWSDm (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 23 Jun 2015 14:03:42 -0400
Date: Tue, 23 Jun 2015 20:02:25 +0200
From: Oleg Nesterov <oleg@redhat.com>
To: Andy Lutomirski <luto@amacapital.net>,
        Andrew Morton <akpm@linux-foundation.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>, Benjamin LaHaise <bcrl@kvack.org>,
        Hugh Dickins <hughd@google.com>, Jeff Moyer <jmoyer@redhat.com>,
        Kirill Shutemov <kirill.shutemov@linux.intel.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Andy Lutomirski <luto@kernel.org>,
        Pavel Emelyanov <xemul@parallels.com>
Subject: [PATCH 0/1] mm: move ->mremap() from file_operations to
	vm_operations_struct
Message-ID: <20150623180225.GA12882@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 06/22, Andy Lutomirski wrote:
>
> On Mon, Jun 22, 2015 at 5:47 PM, Oleg Nesterov <oleg@redhat.com> wrote:
> >
> > I never understood why ->mremap() lives in file_operations, not in
> > vm_operations_struct. To me vma->vm_file->f_op in move_vma() just
> > looks strange, vma->vm_ops->mremap(new_vma) looks "obviously better".
> >
> > And afaics more useful. CRIU remaps vdso, but this does not update
> > mm->context.vdso. OK, probably this does not matter currently, CRIU
> > can't c/r the compat tasks, and 64-bit apps do not use context.vdso.
> > Afaics. Still, I think we might want to have special_mapping_remap()
> > and we can't do this because ->vm_file == NULL.
>
> I would like this.  Then I could clean up and resubmit my patch to
> keep context.vdso up to date.

Cough... where can I find this patch ? ;)

> Oleg, can you let me know what patch, if any, I should be reviewing?

This one, it looks really trivial. And of course I will appreciate it
if you can review the special_mapping_fault() fixes.

The change in move_vma() textually depends on another patch I sent,

	[PATCH 1/4] mremap: don't leak new_vma if f_op->mremap() fails
	http://marc.info/?l=linux-kernel&m=143475603713622

Oleg.