From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932531AbbFWSN2 (ORCPT ); Tue, 23 Jun 2015 14:13:28 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:53411 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751055AbbFWSNU (ORCPT ); Tue, 23 Jun 2015 14:13:20 -0400 Date: Tue, 23 Jun 2015 20:13:10 +0200 From: Peter Zijlstra To: KY Srinivasan Cc: "gregkh@linuxfoundation.org" , "linux-kernel@vger.kernel.org" , "devel@linuxdriverproject.org" , "mingo@kernel.org" , "rafael.j.wysocki@intel.com" , "tglx@linutronix.de" , Vitaly Kuznetsov Subject: Re: [PATCH 1/1] cpu-hotplug: export cpu_hotplug_enable/cpu_hotplug_disable Message-ID: <20150623181310.GG3644@twins.programming.kicks-ass.net> References: <1434941760-16858-1-git-send-email-kys@microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 23, 2015 at 04:57:05PM +0000, KY Srinivasan wrote: > > diff --git a/kernel/cpu.c b/kernel/cpu.c > > index 94bbe46..8f35ee6 100644 > > --- a/kernel/cpu.c > > +++ b/kernel/cpu.c > > @@ -190,17 +190,19 @@ void cpu_hotplug_done(void) > > void cpu_hotplug_disable(void) > > { > > cpu_maps_update_begin(); > > - cpu_hotplug_disabled = 1; > > + cpu_hotplug_disabled++; > > cpu_maps_update_done(); > > } > > +EXPORT_SYMBOL_GPL(cpu_hotplug_disable); > > > > void cpu_hotplug_enable(void) > > { > > cpu_maps_update_begin(); > > - cpu_hotplug_disabled = 0; > > + if (cpu_hotplug_disabled) > > + cpu_hotplug_disabled--; No that just papers over bugs. > > cpu_maps_update_done(); > > }