Re: [PATCH v2 4/8] input: goodix: reset device at init

Bastien Nocera
2015-06-09T15:34:53Z

On Mon, 2015-06-08 at 17:37 +0300, Irina Tirdea wrote:
> After power on, it is recommended that the driver resets the device.
> The reset procedure timing is described in the datasheet and is used
> at device init (before writing device configuration) and
> for power management. It is a sequence of setting the interrupt
> and reset pins high/low at specific timing intervals. This procedure
> also includes setting the slave address to the one specified in the
> ACPI/device tree.

This breaks the touchscreen on my Onda v975w:
[ 239.732858] Goodix-TS i2c-GDIX1001:00: ID 9271, version: 1020
[ 239.732977] Goodix-TS i2c-GDIX1001:00: Failed to get reset GPIO: -16
[ 239.736071] Goodix-TS: probe of i2c-GDIX1001:00 failed with error -16

This is the DSDT for that device: