public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Luis de Bethencourt <luis@debethencourt.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
	Kirk Reiser <kirk@reisers.ca>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	speakup@linux-speakup.org,
	Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
	Domagoj Trsan <domagoj.trsan@gmail.com>,
	Samuel Thibault <samuel.thibault@ens-lyon.org>,
	Chris Brannon <chris@the-brannons.com>
Subject: Re: [PATCH] staging: speakup: replace simple_strtoul() with kstrtoint()
Date: Wed, 24 Jun 2015 00:15:52 +0100	[thread overview]
Message-ID: <20150623231552.GA19085@turing> (raw)
In-Reply-To: <20150623225333.GQ28762@mwanda>

On Wed, Jun 24, 2015 at 01:53:33AM +0300, Dan Carpenter wrote:
> Nope.  Your patch is totally wrong (buggy).  Please be more careful in
> the future.
> 
> regards,
> dan carpenter
> 

I saw other commits replace the obsolete simple_strtoul() this way and the
documentation makes it look like it is a 1 to 1 replacement.

Sorry about this. I will investigate further to understand why this is buggy
and be more careful in the future.

Thanks for the review,
Luis

  reply	other threads:[~2015-06-23 23:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-23 20:47 [PATCH] staging: speakup: replace simple_strtoul() with kstrtoint() Luis de Bethencourt
2015-06-23 22:53 ` Dan Carpenter
2015-06-23 23:15   ` Luis de Bethencourt [this message]
2015-06-24  5:23     ` Sudip Mukherjee
2015-06-24 10:19       ` Luis de Bethencourt
2015-06-24 17:46         ` Luis de Bethencourt
2015-06-25  8:19           ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150623231552.GA19085@turing \
    --to=luis@debethencourt.com \
    --cc=aysemelikeyurtoglu@gmail.com \
    --cc=chris@the-brannons.com \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=domagoj.trsan@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kirk@reisers.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=samuel.thibault@ens-lyon.org \
    --cc=speakup@linux-speakup.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox