From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934036AbbFXDLK (ORCPT ); Tue, 23 Jun 2015 23:11:10 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:39913 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933532AbbFXDLD (ORCPT ); Tue, 23 Jun 2015 23:11:03 -0400 Date: Tue, 23 Jun 2015 20:11:02 -0700 From: Greg KH To: Vitaly Kuznetsov Cc: Olaf Hering , "K. Y. Srinivasan" , linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, apw@canonical.com, jasowang@redhat.com Subject: Re: [PATCH V2 04/10] Drivers: hv: vmbus: add special kexec handler Message-ID: <20150624031102.GA21093@kroah.com> References: <1433460339-9346-1-git-send-email-kys@microsoft.com> <1433460376-9387-1-git-send-email-kys@microsoft.com> <1433460376-9387-4-git-send-email-kys@microsoft.com> <20150623075719.GA19219@gmail.com> <87381i8k3v.fsf@vitty.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87381i8k3v.fsf@vitty.brq.redhat.com> User-Agent: Mutt/1.5.23+89 (0255b37be491) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 23, 2015 at 06:28:36PM +0200, Vitaly Kuznetsov wrote: > Olaf Hering writes: > > > On Thu, Jun 04, K. Y. Srinivasan wrote: > > > >> +++ b/arch/x86/kernel/cpu/mshyperv.c > >> @@ -18,6 +18,9 @@ > >> #include > >> #include > >> #include > >> +#ifdef CONFIG_KEXEC > >> +#include > >> +#endif > > > > Is this #ifdef required? > > > > No, it's not, but other parts of the same patch do (e.g. there is no > kexec_in_progress without CONFIG_KEXEC). We can probably omit #ifdef > here but I'm not sure it makes sense. No #ifdef should be in a .c file if at all possible, so please remove them all if you can. If not, then work to fix up the .h file properly so that you can. thanks, greg k-h