From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: problem with checkpatch
Date: Wed, 24 Jun 2015 10:12:26 +0530 [thread overview]
Message-ID: <20150624044226.GA3429@sudip-PC> (raw)
In-Reply-To: <1435080706.9808.39.camel@perches.com>
On Tue, Jun 23, 2015 at 10:31:46AM -0700, Joe Perches wrote:
> On Tue, 2015-06-23 at 18:06 +0530, Sudip Mukherjee wrote:
> > Hi Joe,
> > while checking patches I usually check them using mutt pipe to checkpatch.
> > while in mutt, press '|' and then scripts/checkpatch.pl -
> > and the patch will be checked by checkpatch without having to save it.
> >
> > Now 700152391c3d ("checkpatch: add --showfile to allow input via pipe to show filenames")
> > is adding $filename ne '-' and because of that if the patch has any
> > error in Signed-off-by , it is not detecting anymore.
>
> Any error in signature format should still be found,
> but a missing sign-off line would not.
yes, the patch with which i noticed this was not having the Signed-off
regards
sudip
prev parent reply other threads:[~2015-06-24 4:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-23 12:36 problem with checkpatch Sudip Mukherjee
2015-06-23 17:31 ` Joe Perches
2015-06-24 4:42 ` Sudip Mukherjee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150624044226.GA3429@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox