From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751302AbbFXEmn (ORCPT ); Wed, 24 Jun 2015 00:42:43 -0400 Received: from mail-pd0-f175.google.com ([209.85.192.175]:33689 "EHLO mail-pd0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750731AbbFXEmf (ORCPT ); Wed, 24 Jun 2015 00:42:35 -0400 Date: Wed, 24 Jun 2015 10:12:26 +0530 From: Sudip Mukherjee To: Joe Perches Cc: linux-kernel@vger.kernel.org Subject: Re: problem with checkpatch Message-ID: <20150624044226.GA3429@sudip-PC> References: <20150623123640.GA14297@sudip-PC> <1435080706.9808.39.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1435080706.9808.39.camel@perches.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 23, 2015 at 10:31:46AM -0700, Joe Perches wrote: > On Tue, 2015-06-23 at 18:06 +0530, Sudip Mukherjee wrote: > > Hi Joe, > > while checking patches I usually check them using mutt pipe to checkpatch. > > while in mutt, press '|' and then scripts/checkpatch.pl - > > and the patch will be checked by checkpatch without having to save it. > > > > Now 700152391c3d ("checkpatch: add --showfile to allow input via pipe to show filenames") > > is adding $filename ne '-' and because of that if the patch has any > > error in Signed-off-by , it is not detecting anymore. > > Any error in signature format should still be found, > but a missing sign-off line would not. yes, the patch with which i noticed this was not having the Signed-off regards sudip