* problem with checkpatch
@ 2015-06-23 12:36 Sudip Mukherjee
2015-06-23 17:31 ` Joe Perches
0 siblings, 1 reply; 3+ messages in thread
From: Sudip Mukherjee @ 2015-06-23 12:36 UTC (permalink / raw)
To: joe; +Cc: linux-kernel
Hi Joe,
while checking patches I usually check them using mutt pipe to checkpatch.
while in mutt, press '|' and then scripts/checkpatch.pl -
and the patch will be checked by checkpatch without having to save it.
Now 700152391c3d ("checkpatch: add --showfile to allow input via pipe to show filenames")
is adding $filename ne '-' and because of that if the patch has any
error in Signed-off-by , it is not detecting anymore.
Any solution for this?
regards
sudip
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: problem with checkpatch
2015-06-23 12:36 problem with checkpatch Sudip Mukherjee
@ 2015-06-23 17:31 ` Joe Perches
2015-06-24 4:42 ` Sudip Mukherjee
0 siblings, 1 reply; 3+ messages in thread
From: Joe Perches @ 2015-06-23 17:31 UTC (permalink / raw)
To: Sudip Mukherjee; +Cc: linux-kernel
On Tue, 2015-06-23 at 18:06 +0530, Sudip Mukherjee wrote:
> Hi Joe,
> while checking patches I usually check them using mutt pipe to checkpatch.
> while in mutt, press '|' and then scripts/checkpatch.pl -
> and the patch will be checked by checkpatch without having to save it.
>
> Now 700152391c3d ("checkpatch: add --showfile to allow input via pipe to show filenames")
> is adding $filename ne '-' and because of that if the patch has any
> error in Signed-off-by , it is not detecting anymore.
Any error in signature format should still be found,
but a missing sign-off line would not.
> Any solution for this?
Modifying checkpatch or using an older version.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: problem with checkpatch
2015-06-23 17:31 ` Joe Perches
@ 2015-06-24 4:42 ` Sudip Mukherjee
0 siblings, 0 replies; 3+ messages in thread
From: Sudip Mukherjee @ 2015-06-24 4:42 UTC (permalink / raw)
To: Joe Perches; +Cc: linux-kernel
On Tue, Jun 23, 2015 at 10:31:46AM -0700, Joe Perches wrote:
> On Tue, 2015-06-23 at 18:06 +0530, Sudip Mukherjee wrote:
> > Hi Joe,
> > while checking patches I usually check them using mutt pipe to checkpatch.
> > while in mutt, press '|' and then scripts/checkpatch.pl -
> > and the patch will be checked by checkpatch without having to save it.
> >
> > Now 700152391c3d ("checkpatch: add --showfile to allow input via pipe to show filenames")
> > is adding $filename ne '-' and because of that if the patch has any
> > error in Signed-off-by , it is not detecting anymore.
>
> Any error in signature format should still be found,
> but a missing sign-off line would not.
yes, the patch with which i noticed this was not having the Signed-off
regards
sudip
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-06-24 4:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-23 12:36 problem with checkpatch Sudip Mukherjee
2015-06-23 17:31 ` Joe Perches
2015-06-24 4:42 ` Sudip Mukherjee
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox