From: Lee Jones <lee.jones@linaro.org>
To: Mathias Krause <minipli@googlemail.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
linux-kernel@vger.kernel.org, "Yang, Bin" <bin.yang@intel.com>,
"Zhu, Lejun" <lejun.zhu@linux.intel.com>
Subject: Re: [PATCH] mfd: intel_soc_pmic: Constify ACPI device ids
Date: Wed, 24 Jun 2015 11:59:54 +0100 [thread overview]
Message-ID: <20150624105954.GF15013@x1> (raw)
In-Reply-To: <1434198051-8121-1-git-send-email-minipli@googlemail.com>
On Sat, 13 Jun 2015, Mathias Krause wrote:
> Constify the ACPI device ID array, it doesn't need to be writable at
> runtime.
>
> Signed-off-by: Mathias Krause <minipli@googlemail.com>
> Cc: Yang, Bin <bin.yang@intel.com>
> Cc: Zhu, Lejun <lejun.zhu@linux.intel.com>
> ---
> drivers/mfd/intel_soc_pmic_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied for v4.3, thanks.
> diff --git a/drivers/mfd/intel_soc_pmic_core.c b/drivers/mfd/intel_soc_pmic_core.c
> index 7b50b6b208a5..27e7552a29dd 100644
> --- a/drivers/mfd/intel_soc_pmic_core.c
> +++ b/drivers/mfd/intel_soc_pmic_core.c
> @@ -147,7 +147,7 @@ static const struct i2c_device_id intel_soc_pmic_i2c_id[] = {
> MODULE_DEVICE_TABLE(i2c, intel_soc_pmic_i2c_id);
>
> #if defined(CONFIG_ACPI)
> -static struct acpi_device_id intel_soc_pmic_acpi_match[] = {
> +static const struct acpi_device_id intel_soc_pmic_acpi_match[] = {
> {"INT33FD", (kernel_ulong_t)&intel_soc_pmic_config_crc},
> { },
> };
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2015-06-24 11:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-13 12:20 [PATCH] mfd: intel_soc_pmic: Constify ACPI device ids Mathias Krause
2015-06-24 10:59 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150624105954.GF15013@x1 \
--to=lee.jones@linaro.org \
--cc=bin.yang@intel.com \
--cc=lejun.zhu@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minipli@googlemail.com \
--cc=rjw@rjwysocki.net \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox