public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: christian.ruppert@alitech.com
Cc: Lucas De Marchi <lucas.de.marchi@gmail.com>,
	Christian Ruppert <christian.ruppert@abilis.com>,
	Fabio Mello <fabio.mello@intel.com>,
	Jarkko Nikula <jarkko.nikula@linux.intel.com>,
	linux-i2c@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>,
	Lucas De Marchi <lucas.demarchi@intel.com>,
	Wolfram Sang <wsa@the-dreams.de>
Subject: Re: [PATCH] i2c: designware: use enable on resume instead initialization
Date: Wed, 24 Jun 2015 14:27:23 +0300	[thread overview]
Message-ID: <20150624112723.GE827@lahna.fi.intel.com> (raw)
In-Reply-To: <OFB918064C.F72245F4-ONC1257E6E.00287EC7-C1257E6E.00299EF2@alitech.com>

On Wed, Jun 24, 2015 at 09:36:43AM +0200, christian.ruppert@alitech.com wrote:
> Dear Lucas,
> 
> Lucas De Marchi <lucas.de.marchi@gmail.com> wrote on 23.06.2015 19:02:03:
> > On Tue, Jun 23, 2015 at 1:45 PM,  <christian.ruppert@alitech.com> wrote:
> > > Hello,
> > >
> > > Christian Ruppert/ALi_GVA/ALi wrote on 10.06.2015 17:05:16:
> > [...]
> > > The result is not very encouraging: Out of five (identical) designware 
> i2c
> > > controllers we have on my test SOC, the first one initialises properly 
> but
> > > the second one gets stuck in the famous irq loop right away when the
> > > module is enabled in i2c_dw_init. The system never gets around to try
> > 
> > Are you using the pci or platform driver?  I noticed yesterday the pci
> > version is failing here with a NULL pointer dereference.
> 
> The test was performed with the platform driver (instantiated through 
> device tree).
> I just re-checked and the ultimate problem which hangs/kills the system in 
> my case is the IRQ loop.
> I haven't observed any NULL pointer dereferences on the road.

Thanks Christian for testing.

Since the patch causes problems on your hardware, I don't think it is
good idea to merge it.

  reply	other threads:[~2015-06-24 11:29 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-08 17:50 [PATCH] i2c: designware: use enable on resume instead initialization lucas.de.marchi
2015-06-09  8:51 ` Mika Westerberg
2015-06-09 18:29   ` Lucas De Marchi
2015-06-10  7:07     ` Mika Westerberg
     [not found]       ` <OF847FFF39.1FF5F96A-ONC1257E60.00506AFD-C1257E60.0052A8CE@alitech.com>
2015-06-11  9:38         ` Mika Westerberg
2015-06-11 14:48         ` Lucas De Marchi
     [not found]       ` <OF847FFF39.1FF5F96A-ONC1257E60.00506AFD-C1257E60.0052A8CE@LocalDomain>
2015-06-23 16:45         ` christian.ruppert
2015-06-23 17:02           ` Lucas De Marchi
2015-06-24  7:36             ` christian.ruppert
2015-06-24 11:27               ` Mika Westerberg [this message]
2015-06-24 12:56                 ` De Marchi, Lucas
2015-06-24 13:18                   ` mika.westerberg
2015-06-24 14:06                   ` christian.ruppert
2015-06-10  7:55 ` Mika Westerberg
2015-06-12 22:45   ` Lucas De Marchi
2015-06-15  9:29     ` Mika Westerberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150624112723.GE827@lahna.fi.intel.com \
    --to=mika.westerberg@linux.intel.com \
    --cc=christian.ruppert@abilis.com \
    --cc=christian.ruppert@alitech.com \
    --cc=fabio.mello@intel.com \
    --cc=jarkko.nikula@linux.intel.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lucas.de.marchi@gmail.com \
    --cc=lucas.demarchi@intel.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox