From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753299AbbFXMuH (ORCPT ); Wed, 24 Jun 2015 08:50:07 -0400 Received: from muru.com ([72.249.23.125]:59502 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752718AbbFXMuD (ORCPT ); Wed, 24 Jun 2015 08:50:03 -0400 Date: Wed, 24 Jun 2015 05:49:57 -0700 From: Tony Lindgren To: Roger Quadros Cc: Kishon Vijay Abraham I , bcousson@baylibre.com, balbi@ti.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@arm.linux.org.uk, gregkh@linuxfoundation.org, nsekhar@ti.com Subject: Re: [PATCH 08/17] ARM: dts: dra7: Add dt node for the sycon pcie Message-ID: <20150624124956.GH4156@atomide.com> References: <1435060743-5511-1-git-send-email-kishon@ti.com> <1435060743-5511-9-git-send-email-kishon@ti.com> <20150624145017.9b70a1fba477d8b99ce85702@ti.com> <20150624145617.e5248d466fe5b2e0eb1ca087@ti.com> <20150624120938.GG4156@atomide.com> <20150624151931.87252315d0e61ddfd55c4724@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150624151931.87252315d0e61ddfd55c4724@ti.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Roger Quadros [150624 05:21]: > On Wed, 24 Jun 2015 05:09:39 -0700 > Tony Lindgren wrote: > > > > My take is we should only use regmap for the scm_conf area > > in general. > > +1 > > should we get rid of dra7_ctrl_core and dra7_ctrl_general? > or move them to scm node? Well at least move them. And if there are clear dedicated register ranges there claimed only by a single device driver, then those drivers should be just regular loadable driver modules doing of_ioremap on the range. And in that case they can be removed. We have examples of both in dra7.dtsi, pbias_regulator using the scm_conf via syscon, and then dra7_pmx_core ioremapping a dedicated register range. So unless there are other messy register ranges like the scm_conf area then there should not be need for other syscon areas. Regards, Tony