public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: linux-kernel@vger.kernel.org,
	Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
	Heiko Stuebner <heiko@sntech.de>, Olof Johansson <olof@lixom.net>,
	Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH] mfd: fix dependency warning for CHROME_PLATFORMS on !X86, !ARM
Date: Wed, 24 Jun 2015 15:17:22 +0100	[thread overview]
Message-ID: <20150624141722.GP15013@x1> (raw)
In-Reply-To: <1434844916-5412-1-git-send-email-paul.gortmaker@windriver.com>

On Sat, 20 Jun 2015, Paul Gortmaker wrote:

> In commit 062476f24aa7cf714169342cc50626fd9bbb93da ("mfd: cros_ec:
> Move protocol helpers out of the MFD driver") there was a select
> added on CHROME_PLATFORMS, which leads to the following for ppc/mips:
> 
> warning: (MFD_CROS_EC) selects CHROME_PLATFORMS which has unmet
> direct dependencies (X86 || ARM)
> 
> Presumably the above means MFD_CROS_EC is only currently useful
> on x86 and ARM, so lets limit it to there.
> 
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: Olof Johansson <olof@lixom.net>
> Cc: Samuel Ortiz <sameo@linux.intel.com>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> ---
>  drivers/mfd/Kconfig | 1 +
>  1 file changed, 1 insertion(+)

Applied, thanks.

> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 653815950aa2..d3235e6f1953 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -94,6 +94,7 @@ config MFD_AXP20X
>  
>  config MFD_CROS_EC
>  	tristate "ChromeOS Embedded Controller"
> +	depends on X86 || ARM
>  	select MFD_CORE
>  	select CHROME_PLATFORMS
>  	select CROS_EC_PROTO

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

      parent reply	other threads:[~2015-06-24 14:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-21  0:01 [PATCH] mfd: fix dependency warning for CHROME_PLATFORMS on !X86, !ARM Paul Gortmaker
2015-06-21  0:17 ` Javier Martinez Canillas
2015-06-24 14:17   ` Lee Jones
2015-06-24 14:21     ` Heiko Stübner
2015-06-24 14:30       ` Javier Martinez Canillas
2015-06-24 14:17 ` Lee Jones [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150624141722.GP15013@x1 \
    --to=lee.jones@linaro.org \
    --cc=heiko@sntech.de \
    --cc=javier.martinez@collabora.co.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=paul.gortmaker@windriver.com \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox