public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jeff Chua <jeff.chua.linux@gmail.com>
Cc: Martin Steigerwald <martin@lichtvoll.de>,
	Andreas Mohr <andi@lisas.de>, lkml <linux-kernel@vger.kernel.org>,
	Christoph Hellwig <hch@lst.de>
Subject: Re: Stop SSD from waiting for "Spinning up disk..."
Date: Wed, 24 Jun 2015 09:28:52 -0700	[thread overview]
Message-ID: <20150624162852.GA29182@kroah.com> (raw)
In-Reply-To: <CAAJw_Zs3vGgUW6hzeZ=Z50tREBU=U385+t1YRrO2nQHsgvx4hA@mail.gmail.com>

On Thu, Jun 25, 2015 at 12:22:47AM +0800, Jeff Chua wrote:
> On Wed, Jun 24, 2015 at 2:55 AM, Martin Steigerwald <martin@lichtvoll.de> wrote:
> > Am Dienstag, 23. Juni 2015, 20:26:12 schriebst Du:
> >> Hi,
> >
> > Hi,
> >
> >> [proper In-Reply-To trail missing since lkml.org now fails to provide it]
> > […]
> >> > Greg,
> >> >
> >> > SSD is coming mainstream and it doesn't make sense wasting time
> >> > spinning up "disk" ...
> >>
> >> ...which probably is not truly being achieved
> >> by providing a *custom* kernel parameter
> >> which does apply to only those disk instances
> >> which some users *specifically* care about.
> >>
> >> Some things come to mind:
> >>
> >> - at this scope, generally spoken
> >>   one shouldn't be concerned with whether "we are SSD",
> >>   but rather whether "we (do not) need spinup"
> >>   (which might apply to a ton of different SCSI-based storage devices,
> >>   even some SAN-based platter-based ones)
> >>   *This* is what this is about
> >>   (and this could then have been reflected in kernel parameter naming)
> > […]
> >> - the kernel must already have some mechanisms to discern between
> >> (non-)platters (e.g. perhaps for knowing whether to support SSD TRIM
> >> command)
> >
> > Yep, for the first SSD in this laptop:
> >
> > merkaba:/sys> cat
> > ./devices/pci0000:00/0000:00:1f.2/ata2/host1/target1:0:0/1:0:0:0/block/sda/queue/rotational
> > 0
> 
> 
> It seems "rotational" is not reporting the correct status on USB devices ...
> 
> # cat /sys/devices/pci0000:00/0000:00:1f.2/ata1/host0/target0:0:0/0:0:0:0/block/sda/queue/rotational
> 0
> # cat sys/devices/pci0000:00/0000:00:14.0/usb2/2-1/2-1:1.0/host10/target10:0:0/10:0:0:0/block/sdb/queue/rotational
> 1
> 
> # dmesg
> scsi host11: uas
> scsi 10:0:0:0: Direct-Access     JMicron  Generic          0114 PQ: 0 ANSI: 6
> 
> # cat /sys/kernel/debug/usb/devices
> T:  Bus=02 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#=  4 Spd=5000 MxCh= 0
> D:  Ver= 3.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS= 9 #Cfgs=  1
> P:  Vendor=152d ProdID=0567 Rev= 1.14
> S:  Manufacturer=JMicron
> S:  Product=USB to ATA/ATAPI Bridge
> S:  SerialNumber=3186E514500030
> C:* #Ifs= 1 Cfg#= 1 Atr=c0 MxPwr=  8mA
> I:  If#= 0 Alt= 0 #EPs= 2 Cls=08(stor.) Sub=06 Prot=50 Driver=uas
> 
> 
> Both sda and sdb have the same SSD model.

That's a bug in your USB bridge chip, odds are it is not reporting the
value properly.  There's nothing the scsi core or USB stack can do about
this, sorry.  Please complain to the hardware manufacturer.

greg k-h

  reply	other threads:[~2015-06-24 16:29 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-23 18:26 Stop SSD from waiting for "Spinning up disk..." Andreas Mohr
2015-06-23 18:55 ` Martin Steigerwald
2015-06-24 16:22   ` Jeff Chua
2015-06-24 16:28     ` Greg Kroah-Hartman [this message]
2015-06-24 23:55       ` Jeff Chua
2015-06-25  1:41         ` Greg Kroah-Hartman
2015-06-25  6:08           ` Martin Steigerwald
2015-06-25  8:52             ` Jeff Chua
  -- strict thread matches above, loose matches on Subject: below --
2015-06-22  7:25 Jeff Chua
2015-06-22 15:36 ` Greg Kroah-Hartman
2015-06-23 15:02   ` Jeff Chua
2015-06-23 18:27     ` Frans Klaver
2015-06-23 18:51     ` Marc Burkhardt
2015-06-25 16:21 ` Henrique de Moraes Holschuh
2015-06-25 16:47   ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150624162852.GA29182@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=andi@lisas.de \
    --cc=hch@lst.de \
    --cc=jeff.chua.linux@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin@lichtvoll.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox