From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751428AbbFYGaC (ORCPT <rfc822;w@1wt.eu>);
	Thu, 25 Jun 2015 02:30:02 -0400
Received: from zeniv.linux.org.uk ([195.92.253.2]:58580 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751023AbbFYG3v (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 25 Jun 2015 02:29:51 -0400
Date: Thu, 25 Jun 2015 07:29:46 +0100
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux FS Dev Mailing List <linux-fsdevel@vger.kernel.org>,
        Linux F2FS Dev Mailing List 
	<linux-f2fs-devel@lists.sourceforge.net>,
        Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [GIT PULL] f2fs updates for v4.2
Message-ID: <20150625062946.GU17109@ZenIV.linux.org.uk>
References: <20150624202401.GA40031@jaegeuk-mac02.mot.com>
 <CA+55aFycRo0ttWw5kAgf=tDrfz-hvhSsjveu9LqdXH-RNbXE3A@mail.gmail.com>
 <20150625043334.GT17109@ZenIV.linux.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150625043334.GT17109@ZenIV.linux.org.uk>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jun 25, 2015 at 05:33:34AM +0100, Al Viro wrote:

> Said that, f2fs_symlink() looks odd - we create a directory entry *before*
> doing page_symlink().  And if it (or encryption) fails, I don't see anything
> that would remove that new directory entry.  What are we ending up with
> in such case?

PS: other page_symlink() users tend to do it first and if it fails we just
decrement link count and iput() the sucker.

	BTW, while grepping for that stuff...  Why do we have
->delete_inode() set to generic_delete_inode() on ramfs?  After all,
we never hash the inodes in there, so default will do nicely, and
it's kinder of branch prediction - we have
        if (op->drop_inode)
                drop = op->drop_inode(inode);
        else
                drop = generic_drop_inode(inode);
and generic_drop_inode() is inlined there...