From: Peter Zijlstra <peterz@infradead.org>
To: Dave Hansen <dave@sr71.net>
Cc: mingo@redhat.com, linux-kernel@vger.kernel.org,
dave.hansen@linux.intel.com, Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [RFC][PATCH] sched: might_sleep(): do rate-limiting before sanity checks
Date: Thu, 25 Jun 2015 09:43:33 +0200 [thread overview]
Message-ID: <20150625074333.GU3644@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <558B7746.9010605@sr71.net>
On Wed, Jun 24, 2015 at 08:36:38PM -0700, Dave Hansen wrote:
> On 06/24/2015 05:03 PM, Dave Hansen wrote:
> > In any case, we ratelimit might_sleep() checks anyway. But, we
> > do the ratelimiting *after* we check the other conditions for
> > might_sleep() including the (costly) irqs_disabled() call.
>
> Thinking about this a bit more, this patch is wrong.
>
> This only does a _check_ once per jiffy instead of just one warning per
> jiffy, which is totally bogus.
>
> I would be interested, though, if anybody has any ideas about speeding
> up the irqs_disabled() checking.
Thomas has something up his sleeve..
prev parent reply other threads:[~2015-06-25 7:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-25 0:03 [RFC][PATCH] sched: might_sleep(): do rate-limiting before sanity checks Dave Hansen
2015-06-25 3:36 ` Dave Hansen
2015-06-25 7:43 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150625074333.GU3644@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=dave.hansen@linux.intel.com \
--cc=dave@sr71.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox