From: Lee Jones <lee.jones@linaro.org>
To: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Cc: linux-samsung-soc@vger.kernel.org,
Heiko Stuebner <heiko@sntech.de>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Gwendal Grignou <gwendal@google.com>,
Doug Anderson <dianders@chromium.org>,
linux-kernel@vger.kernel.org,
Samuel Ortiz <sameo@linux.intel.com>,
Olof Johansson <olof@lixom.net>
Subject: Re: [PATCH 3/3] mfd: Remove MFD_CROS_EC_SPI depends on OF
Date: Thu, 25 Jun 2015 09:38:30 +0100 [thread overview]
Message-ID: <20150625083830.GU15013@x1> (raw)
In-Reply-To: <1435191645-6022-4-git-send-email-javier.martinez@collabora.co.uk>
On Thu, 25 Jun 2015, Javier Martinez Canillas wrote:
> The ChromeOS EC SPI transport driver has a dependency on OF because it
> uses some OF helpers from the <linux/of.h> header. But there isn't a
> need for an explicit dependency since the header has stub functions if
> CONFIG_OF is not defined.
>
> Also, MFD_CROS_EC_SPI already depends on MFD_CROS_EC which in turn has
> a dependency on OF so in practice can't be selected without CONFIG_OF.
>
> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>
> ---
>
> drivers/mfd/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied for v4.3, thanks.
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 653815950aa2..3f68dd251ce8 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -115,7 +115,7 @@ config MFD_CROS_EC_I2C
>
> config MFD_CROS_EC_SPI
> tristate "ChromeOS Embedded Controller (SPI)"
> - depends on MFD_CROS_EC && CROS_EC_PROTO && SPI && OF
> + depends on MFD_CROS_EC && CROS_EC_PROTO && SPI
>
> ---help---
> If you say Y here, you get support for talking to the ChromeOS EC
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2015-06-25 8:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-25 0:20 [PATCH 0/3] mfd: ChromeOS EC Kconfig dependency cleanup Javier Martinez Canillas
2015-06-25 0:20 ` [PATCH 1/3] platform/chrome: Don't make CHROME_PLATFORMS depends on X86 || ARM Javier Martinez Canillas
2015-07-22 1:29 ` Olof Johansson
2015-07-22 7:16 ` Lee Jones
2015-08-17 7:56 ` Geert Uytterhoeven
2015-08-17 8:36 ` Javier Martinez Canillas
2015-06-25 0:20 ` [PATCH 2/3] mfd: Remove MFD_CROS_EC " Javier Martinez Canillas
2015-06-25 8:38 ` Lee Jones
2015-06-25 8:44 ` Javier Martinez Canillas
2015-06-30 6:09 ` Paul Gortmaker
2015-07-22 1:13 ` Paul Gortmaker
2015-07-22 1:27 ` Javier Martinez Canillas
2015-07-22 1:31 ` Olof Johansson
2015-07-22 1:30 ` Olof Johansson
2015-07-22 7:15 ` Lee Jones
2015-06-25 0:20 ` [PATCH 3/3] mfd: Remove MFD_CROS_EC_SPI depends on OF Javier Martinez Canillas
2015-06-25 8:38 ` Lee Jones [this message]
2015-07-22 7:17 ` Lee Jones
2015-08-07 0:03 ` [PATCH 0/3] mfd: ChromeOS EC Kconfig dependency cleanup Javier Martinez Canillas
2015-08-10 16:10 ` Lee Jones
2015-08-10 16:13 ` Lee Jones
2015-08-10 16:45 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150625083830.GU15013@x1 \
--to=lee.jones@linaro.org \
--cc=dianders@chromium.org \
--cc=gwendal@google.com \
--cc=heiko@sntech.de \
--cc=javier.martinez@collabora.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=olof@lixom.net \
--cc=paul.gortmaker@windriver.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox