From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751356AbbFYNpT (ORCPT <rfc822;w@1wt.eu>);
	Thu, 25 Jun 2015 09:45:19 -0400
Received: from mail.kernel.org ([198.145.29.136]:58353 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750786AbbFYNpM (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 25 Jun 2015 09:45:12 -0400
Date: Thu, 25 Jun 2015 10:45:05 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Ingo Molnar <mingo@kernel.org>, linux-kernel@vger.kernel.org,
        Jiri Olsa <jolsa@kernel.org>, Adrian Hunter <adrian.hunter@intel.com>,
        Andi Kleen <ak@linux.intel.com>, David Ahern <dsahern@gmail.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH 12/13] perf thread_map: Change map entries into a struct
Message-ID: <20150625134505.GA3253@kernel.org>
References: <1435096047-32088-1-git-send-email-acme@kernel.org>
 <1435096047-32088-13-git-send-email-acme@kernel.org>
 <20150625083841.GB11451@krava.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150625083841.GB11451@krava.redhat.com>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Thu, Jun 25, 2015 at 10:38:41AM +0200, Jiri Olsa escreveu:
> On Tue, Jun 23, 2015 at 06:47:26PM -0300, Arnaldo Carvalho de Melo wrote:
> > From: Jiri Olsa <jolsa@kernel.org>
> > 
> > We need to store command names with the pid. Changing map entries to be
> > a struct holding pid. Process name is coming in shortly.
> > 
> > Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> > Cc: Adrian Hunter <adrian.hunter@intel.com>
> > Cc: Andi Kleen <ak@linux.intel.com>
> > Cc: David Ahern <dsahern@gmail.com>
> > Cc: Namhyung Kim <namhyung@kernel.org>
> > Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> > Cc: Stephane Eranian <eranian@google.com>
> > Link: http://lkml.kernel.org/r/1435012588-9007-2-git-send-email-jolsa@kernel.org
> > [ Split providing the set/get accessors from transforming the entries structs ]
> 
> the comment in [] is wrong..
> 
> and you missed following hunk:
> 
> ---
>  static struct thread_map *thread_map__realloc(struct thread_map *map, int nr)
>  {
> -       size_t size = sizeof(*map) + sizeof(pid_t) * nr;
> +       size_t size = sizeof(*map) + sizeof(struct thread_map_data) * nr;
> ---
> 
> shouldn't be fatal, it probably has the same or biggger size ATM
> I'll include the fix in the next version

Yeah, sorry about that, should have noticed that, but as you said, code
wise it is harmless.

- Arnaldo