Re: [PATCH 1/4] mfd: da9150: Add support for Fuel-Gauge

[Lee Jones <lee.jones@linaro.org>]

On Thu, 25 Jun 2015, Opensource [Adam Thomson] wrote:

> On June 22, 2015 17:48, Lee Jones wrote:
> 
> > > > The pedant in me noticed that this function is actually added in 3/4. So
> > > > this chunk might be moved to 3/4, if you like to entertain pedantry like
> > > > that, that is. (But see my remark on 3/4 too.)
> > >
> > > This is true, but as the header is part of MFD, I included it as part of that
> > > patch as I thought this made more sense. I guess Lee will comment as to whether
> > > that was correct or not. :)
> > 
> > Glanced over this (as I still have 240 unread emails to attend to).
> > If the question is whether to submit the prototype at the same time as
> > the associated function, the answer is yes.
> 
> Hope you've managed to trawl through the e-mails.
> 
> The question was whether or not the function and prototype should be submitted
> as part of the same individual patch file. Both are submitted as part of the
> patch set but the prototype resides in the MFD patch, and the function in the
> power (fuel-gauge) patch. Personally, this seems fine to me but I'm not a
> maintainer.

Please move the prototype into the same patch that introduced the function.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog