From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751665AbbFYOzu (ORCPT ); Thu, 25 Jun 2015 10:55:50 -0400 Received: from mail-wg0-f50.google.com ([74.125.82.50]:35617 "EHLO mail-wg0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751345AbbFYOzj (ORCPT ); Thu, 25 Jun 2015 10:55:39 -0400 Date: Thu, 25 Jun 2015 15:55:35 +0100 From: Lee Jones To: "Opensource [Adam Thomson]" Cc: Paul Bolle , Samuel Ortiz , Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "linux-pm@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Support Opensource Subject: Re: [PATCH 1/4] mfd: da9150: Add support for Fuel-Gauge Message-ID: <20150625145535.GD23990@x1> References: <8d8f583fee9313f261efa96a038874e552995c17.1434643491.git.Adam.Thomson.Opensource@diasemi.com> <1434732461.2385.162.camel@x220> <2E89032DDAA8B9408CB92943514A0337AB555F28@SW-EX-MBX01.diasemi.com> <20150622111624.GF19061@x1> <2E89032DDAA8B9408CB92943514A0337AB557CA1@SW-EX-MBX01.diasemi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2E89032DDAA8B9408CB92943514A0337AB557CA1@SW-EX-MBX01.diasemi.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 25 Jun 2015, Opensource [Adam Thomson] wrote: > On June 22, 2015 17:48, Lee Jones wrote: > > > > > The pedant in me noticed that this function is actually added in 3/4. So > > > > this chunk might be moved to 3/4, if you like to entertain pedantry like > > > > that, that is. (But see my remark on 3/4 too.) > > > > > > This is true, but as the header is part of MFD, I included it as part of that > > > patch as I thought this made more sense. I guess Lee will comment as to whether > > > that was correct or not. :) > > > > Glanced over this (as I still have 240 unread emails to attend to). > > If the question is whether to submit the prototype at the same time as > > the associated function, the answer is yes. > > Hope you've managed to trawl through the e-mails. > > The question was whether or not the function and prototype should be submitted > as part of the same individual patch file. Both are submitted as part of the > patch set but the prototype resides in the MFD patch, and the function in the > power (fuel-gauge) patch. Personally, this seems fine to me but I'm not a > maintainer. Please move the prototype into the same patch that introduced the function. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog