From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751682AbbFYUpH (ORCPT <rfc822;w@1wt.eu>);
	Thu, 25 Jun 2015 16:45:07 -0400
Received: from mx1.redhat.com ([209.132.183.28]:55661 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751023AbbFYUpD (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 25 Jun 2015 16:45:03 -0400
Date: Thu, 25 Jun 2015 22:43:42 +0200
From: Oleg Nesterov <oleg@redhat.com>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: Andy Lutomirski <luto@amacapital.net>,
        Andrew Morton <akpm@linux-foundation.org>,
        Al Viro <viro@zeniv.linux.org.uk>, Benjamin LaHaise <bcrl@kvack.org>,
        Hugh Dickins <hughd@google.com>, Jeff Moyer <jmoyer@redhat.com>,
        Kirill Shutemov <kirill.shutemov@linux.intel.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Andy Lutomirski <luto@kernel.org>,
        Pavel Emelyanov <xemul@parallels.com>
Subject: Re: [PATCH 1/1] mm: move ->mremap() from file_operations to
	vm_operations_struct
Message-ID: <20150625204342.GA31034@redhat.com>
References: <20150623180225.GA12882@redhat.com> <20150623180251.GA13131@redhat.com> <20150623181945.GA13390@node.dhcp.inet.fi> <20150623182655.GA21392@redhat.com> <20150624154914.GA6127@redhat.com> <20150624192313.GA19249@node.dhcp.inet.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150624192313.GA19249@node.dhcp.inet.fi>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 06/24, Kirill A. Shutemov wrote:
>
> On Wed, Jun 24, 2015 at 05:49:14PM +0200, Oleg Nesterov wrote:
> >
> > Wait... Documentation/filesystems/Locking doesn't mention
> > ->mremap() at all.
> >
> > So you actually ask me to add the new documentation? ;)
>
> I tried ;)

Understand ;) but I failed to do this. Serisouly, I simply don't
know what can I add into this (outadted anyway) section except
"called when move_page_tables() targets this vma".

> > I tried to make the minimal change before ->mremap() finds another
> > user in file_operations. I thinks it needs more arguments, at least
> > new_addr and new_len, otherwise it is not easy to document it. The
> > same for f_op->mremap() of course.
> >
> > Currently this does not matter, the only user is aio.c and
> > VM_DONTEXPAND means that it is not mergeable, so mremap() always
> > creates the new vma.
> >
> > Hmm. Can't we do this change and add the documentation later?
>
> I'm fine with that.

OK, so I am sending v2 with the only change: rename aio_ring_remap
to aio_ring_mremap as you suggested.

Oleg.