From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752133AbbFYVtU (ORCPT ); Thu, 25 Jun 2015 17:49:20 -0400 Received: from mx.mylinuxtime.de ([148.251.109.235]:53544 "EHLO mx.mylinuxtime.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751201AbbFYVtN (ORCPT ); Thu, 25 Jun 2015 17:49:13 -0400 DKIM-Filter: OpenDKIM Filter v2.9.2 mx.mylinuxtime.de 5B81124BF7 Date: Thu, 25 Jun 2015 23:49:05 +0200 From: Christian Hesse To: David Herrmann Cc: linux-kernel , Herbert Xu , Greg Kroah-Hartman Subject: Re: Linux 4.0.6 breaks my disk/lvm/filesystem setup Message-ID: <20150625234905.2cdec4ab@leda.localdomain> In-Reply-To: References: <20150623101444.02d93b5a@leda.localdomain> <20150625090502.5fb6588c@leda.localdomain> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.28; x86_64-unknown-linux-gnu) X-Face: %O:rCSkHSKf7^4uF|FD$9$I0}g$nbnS1{DYPvs#:,~e`).mzj\$P9]V!WCveE/XdbL,L!{)6v%x4\Bt!b#{;dS&h"7l=ow'^({02!2%XOugod|u*mYBVm-OS:VpZ"ZrRA4[Q&zye,^j;ftj!Hxx\1@;LM)Pz)|B%1#sfF;s;,N?*K*^) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAGFBMVEUZFRFENy6KVTKEd23CiGHeqofJvrX4+vdHgItOAAAACXBIWXMAAA3XAAAN1wFCKJt4AAACUklEQVQ4y2VUTZeqMAxNxXG2Io5uGd64L35unbF9ax0b3OLxgFs4PcLff0lBHeb1QIq5uelNCEJNq/TIFGyeC+iugH0WJr+B1MvzWASpuP4CYHOB0VfoDdddwA7OIFQIEHjXDiCtV5e9QX0WMu8AG0mB7g7WP4GqeqVdsi4vv/5kFBvaF/zD7zDquL4DxbrDGDyAsgNYOsJOYzth4Q9ZF6iLV+6TLAT1pi2kuvgAtZxSjoG8cL+8vIn251uoe1OOEWwbIPU04gHsmMsoxyyhYsD2FdIigF1yxaVbBuSOCAlCoX324I7wNMhrO1bhOLsRoA6DC6wQ5eQiSG5BiWQfM4gN+uItQTRDMaJUhVbGyKWCuaaUGSVFVKpl4PdoDn3yY8J+YxQxyhlHfoYOyPgyDcO+cSQK6Bvabjcy2nwRo3pxgA8jslnCuYw23ESOzHAPYwo4ITNQMaOO+RGPEGhSlPEZBh2jmBEjQ5cKbxmr0ruAe/WCriUxW76I8T3h7vqY5VR5wXLdERodg2rHEzdxxk5KpXTL4FwnarvndKM5/MWDY5CuBBdQ+3/0ivsUJHicuHd+Xh3jOdBL+FjSGq4SPCwco+orpWlERRTNo7BHCvbNXFVSIQMp+P5QsIL9upmr8kMTUOfxEHoanwzKRcNAe76WbjBwex/RkdHu48xT5YqP70DaMOhBcTHmAVDxLaBdle93oJy1QKFUh2GXT4am+YH/GGel1CeI98GdMXsytjCKIq/9cMrlgxFCROv+3/BU1fijNpcVD6DxE8VfLBaxUGr1D5usgDYdjwiPAAAAAElFTkSuQmCC MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/ZeDtX6CnCo_zk9vVEhyu1=i"; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Sig_/ZeDtX6CnCo_zk9vVEhyu1=i Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable David Herrmann on Thu, 2015/06/25 14:01: > Hi >=20 > On Thu, Jun 25, 2015 at 9:05 AM, Christian Hesse wrote: > > Hello everybody, > > > > I kind of nailed the issue. Adding CC to Greg for kdbus and to Herbert = for > > the bad commit. Details are below. > > > > Christian Hesse on Tue, 2015/06/23 10:14: > >> with Linux 4.0.5 everything was perfectly fine, Linux 4.0.6 breaks the > >> setup on one of my systems: Only three of my logical volumes are > >> available, systemd reports: > >> > >> lvm2-pvscan@254:3.service: State 'stop-sigterm' timed out. Killing. > >> > >> Followed by a lot of failed dependencies. The setup looks like this: > >> > >> NAME MAJ:MIN RM SIZE RO TYPE MOUNTPOINT > >> sda 8:0 0 953,9G 0 disk > >> |-sda1 8:1 0 1M 0 part > >> |-sda2 8:2 0 256M 0 part /boot/efi > >> |-sda3 8:3 0 7,8G 0 part > >> | |-vg-iso 254:0 0 4G 0 lvm /srv/iso > >> | |-vg-persist 254:1 0 2G 0 lvm /srv/iso/persist > >> | `-vg-boot 254:2 0 128M 0 lvm /boot > >> |-sda4 8:4 0 913,9G 0 part > >> | `-cvg 254:3 0 913,9G 0 crypt > >> | |-cvg-swap 254:4 0 4G 0 lvm [SWAP] > >> | |-cvg-root 254:5 0 40G 0 lvm / > >> | |-cvg-log 254:6 0 1G 0 lvm /var/log > >> | |-cvg-home 254:7 0 500G 0 lvm /home > >> | |-cvg-vbox_win7 254:8 0 32G 0 lvm > >> | |-cvg-vbox_win8 254:9 0 32G 0 lvm > >> | |-cvg-git 254:10 0 12G 0 lvm /srv/git > >> | `-cvg-chroots 254:11 0 16G 0 lvm /var/lib/archbuild > >> `-sda5 8:5 0 32G 0 part > >> > >> Another system is just fine, the only difference is a logical volume w= ith > >> btrfs (cvg-chroots). Possibly the btrfs fixes are involved? > > > > I am running Linux 4.0.x with kdbus from Greg's char-misc tree kdbus > > branch [0] merged, last commit is b69af624a0 ("kdbus: optimize if > > statements in kdbus_conn_disconnect()"). Everything works fine with Lin= ux > > 4.0.5 but breaks with 4.0.6 on one of my systems. > > > > I bisected the problem and found this to be the bad commit [1]: > > > > From cf8befcc1a5538b035d478424efcc2d50e66928e Mon Sep 17 00:00:00 2001 > > From: Herbert Xu > > Date: Sat, 16 May 2015 21:16:28 +0800 > > Subject: netlink: Disable insertions/removals during rehash > > > > [ Upstream commit: Not applicable ] > > > > The current rhashtable rehash code is buggy and can't deal with > > parallel insertions/removals without corrupting the hash table. > > > > This patch disables it by partially reverting > > c5adde9468b0714a051eac7f9666f23eb10b61f7 ("netlink: eliminate > > nl_sk_hash_lock"). > > > > I can fix my system by booting with kdbus=3D0 to disable kdbus or by > > reverting this single commit. Looks like anything deadlocks... Any idea? >=20 > Greg's kdbus tree does not work on 4.0. How exactly did you do the > back-merge? You need to revert these patches at least to make it work > on 4.0 (in this order): > kdbus: no need to ref current->mm > kdbus: use rcu to access exe file in metadata > kdbus: pool: use __vfs_read() > Furthermore, we don't support kdbus on 4.0. So if this does not happen > on 4.1, I'd recommend staying with 4.1. It'd still be interesting to > see whether the netlink-locking back-port is indeed broken. Probably I borked it with my back-merge then... Everything else worked perfectly fine, though. I am on 4.1.0 now, which did not have any issues so far. > Regardless: It is highly unlikely that the netlink commit and kdbus > are in any way related. Either kdbus triggers some uncommon user-space > path, or you have a borked kdbus-merge. I don't know... Possibly the latter. Let's ignore this as it is unsupported. ;) Thanks for your support! --=20 main(a){char*c=3D/* Schoene Gruesse */"B?IJj;MEH" "CX:;",b;for(a/* Chris get my mail address: */=3D0;b=3Dc[a+= +];) putchar(b-1/(/* gcc -o sig sig.c && ./sig */b/42*2-3)*42);} --Sig_/ZeDtX6CnCo_zk9vVEhyu1=i Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVjHdRAAoJEIlFIdfMgPR2UOMH/REqb2HZs/2cXAbDdGal3+ph 4/3dYCucnJG3GzYpMvjJzFNMQ7RjQPjV76Rn3mRDSv+NNvfbYZ8nj2yoirLEQxe9 pAW0frC7ZE9Bs2X5aUBGEbBFqt+L/XZX1k8pN3B3dtpmPYz+aWKDJ2s5J6y5n2WG 4zONf8GgOuNHO9c2HwxMywc5LG7xRsmRTblv4nQITO5DnLK19yCHTOMptjv2tKT3 F2zwSqCqtcP+UaQx7j6+jqV4I8GNGtYKncSFIX1qdQj2WWm+f5csCfwa4Zs+NFig tmbq/sdbJHyMxQMkUL4A126/R1Ow/jlEDxgH06ag18JZybmFAqM+E/M/+G/rJvQ= =82+w -----END PGP SIGNATURE----- --Sig_/ZeDtX6CnCo_zk9vVEhyu1=i--