Re: [PATCH v3 16/19] staging: sm750fb: fix brace placement

Sudip Mukherjee
2015-06-25T12:17:45Z

On Wed, Jun 24, 2015 at 09:25:17AM -0700, Juston Li wrote:
> Fix brace placement errors caught by checkpatch.pl
> ERROR: that open brace { should be on the previous line
>
> Signed-off-by: Juston Li <juston.h.li@gmail.com>
> ---
<snip>
> @@ -71,14 +66,11 @@ static void setDisplayControl(int ctrl, int dispState)
> POKE32(PANEL_DISPLAY_CTRL, ulDisplayCtrlReg);
> }
>
> - }
> /* Set the secondary display control */
> - else
> - {
> + } else {
just a thought. The comment previously was at the beginning of the else
block, but now it will be placed inside the if block - at the end.
will it confuse code readers afterwards?

regards
sudip