From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752459AbbFZKL5 (ORCPT ); Fri, 26 Jun 2015 06:11:57 -0400 Received: from foss.arm.com ([217.140.101.70]:59663 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752400AbbFZKLv (ORCPT ); Fri, 26 Jun 2015 06:11:51 -0400 Date: Fri, 26 Jun 2015 11:11:47 +0100 From: Will Deacon To: Herbert Xu Cc: "linux-kernel@vger.kernel.org" , "linux-crypto@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: arm64 allmodconfig failure =?utf-8?Q?i?= =?utf-8?B?biBleHBhbnNpb24gb2YgbWFjcm8g4oCYX1jigJk=?= Message-ID: <20150626101147.GD1568@arm.com> References: <20150626100805.GC1568@arm.com> <20150626100944.GA19292@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150626100944.GA19292@gondor.apana.org.au> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 26, 2015 at 11:09:44AM +0100, Herbert Xu wrote: > On Fri, Jun 26, 2015 at 11:08:05AM +0100, Will Deacon wrote: > > Hi all, > > > > arm64 allmodconfig fails to build with mainline due to the following: > > > > > > In file included from include/acpi/platform/aclinux.h:74:0, > > from include/acpi/platform/acenv.h:173, > > from include/acpi/acpi.h:56, > > from include/linux/acpi.h:37, > > from ./arch/arm64/include/asm/dma-mapping.h:21, > > from include/linux/dma-mapping.h:86, > > from include/linux/skbuff.h:34, > > from include/crypto/algapi.h:18, > > from crypto/asymmetric_keys/rsa.c:16: > > include/linux/ctype.h:15:12: error: expected ‘;’, ‘,’ or ‘)’ before numeric constant > > #define _X 0x40 /* hex digit */ > > ^ > > crypto/asymmetric_keys/rsa.c:123:47: note: in expansion of macro ‘_X’ > > static int RSA_I2OSP(MPI x, size_t xLen, u8 **_X) > > ^ > > crypto/asymmetric_keys/rsa.c: In function ‘RSA_verify_signature’: > > crypto/asymmetric_keys/rsa.c:256:2: error: implicit declaration of function ‘RSA_I2OSP’ [-Werror=implicit-function-declaration] > > ret = RSA_I2OSP(m, k, &EM); > > > > > > This is thanks to the following function type: > > > > static int RSA_I2OSP(MPI x, size_t xLen, u8 **__X) > > > > conflicting with the _X #define in linux/ctype.h: > > > > #define _X 0x40 /* hex digit */ > > > > Simple patch below, but solving this problem with more underscores feels > > slightly inhumane. > > Thanks but I've already merged a similar patch yesterday. Perfect, sorry for the noise. Will