From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752674AbbFZTJk (ORCPT ); Fri, 26 Jun 2015 15:09:40 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:39415 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752140AbbFZTJP (ORCPT ); Fri, 26 Jun 2015 15:09:15 -0400 Date: Fri, 26 Jun 2015 11:48:05 -0700 From: Greg KH To: Nicholas Krause Cc: mathias.nyman@intel.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] xhci:Change function name from xhci_configure_endpoint_result to xhci_trace_endpoint_result Message-ID: <20150626184805.GA1612@kroah.com> References: <1435343148-6854-1-git-send-email-xerofoify@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1435343148-6854-1-git-send-email-xerofoify@gmail.com> User-Agent: Mutt/1.5.23+89 (0255b37be491) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 26, 2015 at 02:25:48PM -0400, Nicholas Krause wrote: > This changes the name of the function xhci_configure_endpoint_result > to xhci_trace_endpoint_result to more clearly state the actual > intended use of this function which is tracing the passed command > status, on the passed usb/xhci structure pointers of udev and xhci > respectfully. > > Signed-off-by: Nicholas Krause Dammit, my filters broke, I need to go fix them now... > --- > drivers/usb/host/xhci.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c > index 36bf089..2e086ef 100644 > --- a/drivers/usb/host/xhci.c > +++ b/drivers/usb/host/xhci.c > @@ -1839,7 +1839,7 @@ static void xhci_zero_in_ctx(struct xhci_hcd *xhci, struct xhci_virt_device *vir > } > } > > -static int xhci_configure_endpoint_result(struct xhci_hcd *xhci, > +static int xhci_trace_endpoint_result(struct xhci_hcd *xhci, > struct usb_device *udev, u32 *cmd_status) > { > int ret; > @@ -2683,7 +2683,7 @@ static int xhci_configure_endpoint(struct xhci_hcd *xhci, > wait_for_completion(command->completion); > > if (!ctx_change) > - ret = xhci_configure_endpoint_result(xhci, udev, > + ret = xhci_trace_endpoint_result(xhci, udev, > &command->status); No, please stop, this is doing nothing but unneeded code churn, and do absolutely nothing. Because you are banned from vger, these patches are not being sent to the public, so I will not accept them either. I will not be accepting any patches from you for at least a year, maybe two, so don't waste your time. Please go work on some other open source project, if you really want to contribute to the Linux ecosystem, as long as it is not the kernel. greg k-h