From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
stable@vger.kernel.org, Michael Matz <matz@suse.de>,
Borislav Petkov <bp@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>
Subject: [PATCH 4.1 01/11] x86/boot: Fix overflow warning with 32-bit binutils
Date: Fri, 26 Jun 2015 18:09:04 -0700 [thread overview]
Message-ID: <20150627010859.877151900@linuxfoundation.org> (raw)
In-Reply-To: <20150627010859.834155797@linuxfoundation.org>
4.1-stable review patch. If anyone has any objections, please let me know.
------------------
From: Borislav Petkov <bp@alien8.de>
commit 04c17341b42699a5859a8afa05e64ba08a4e5235 upstream.
When building the kernel with 32-bit binutils built with support
only for the i386 target, we get the following warning:
arch/x86/kernel/head_32.S:66: Warning: shift count out of range (32 is not between 0 and 31)
The problem is that in that case, binutils' internal type
representation is 32-bit wide and the shift range overflows.
In order to fix this, manipulate the shift expression which
creates the 4GiB constant to not overflow the shift count.
Suggested-by: Michael Matz <matz@suse.de>
Reported-and-tested-by: Enrico Mioso <mrkiko.rs@gmail.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
arch/x86/kernel/head_32.S | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)
--- a/arch/x86/kernel/head_32.S
+++ b/arch/x86/kernel/head_32.S
@@ -62,9 +62,16 @@
#define PAGE_TABLE_SIZE(pages) ((pages) / PTRS_PER_PGD)
#endif
-/* Number of possible pages in the lowmem region */
-LOWMEM_PAGES = (((1<<32) - __PAGE_OFFSET) >> PAGE_SHIFT)
-
+/*
+ * Number of possible pages in the lowmem region.
+ *
+ * We shift 2 by 31 instead of 1 by 32 to the left in order to avoid a
+ * gas warning about overflowing shift count when gas has been compiled
+ * with only a host target support using a 32-bit type for internal
+ * representation.
+ */
+LOWMEM_PAGES = (((2<<31) - __PAGE_OFFSET) >> PAGE_SHIFT)
+
/* Enough space to fit pagetables for the low memory linear map */
MAPPING_BEYOND_END = PAGE_TABLE_SIZE(LOWMEM_PAGES) << PAGE_SHIFT
next prev parent reply other threads:[~2015-06-27 1:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-27 1:09 [PATCH 4.1 00/11] 4.1.1-stable review Greg Kroah-Hartman
2015-06-27 1:09 ` Greg Kroah-Hartman [this message]
2015-06-27 1:09 ` [PATCH 4.1 02/11] perf: Fix ring_buffer_attach() RCU sync, again Greg Kroah-Hartman
2015-06-27 1:09 ` [PATCH 4.1 03/11] perf/x86: Add more Broadwell model numbers Greg Kroah-Hartman
2015-06-27 1:09 ` [PATCH 4.1 04/11] perf/x86/intel/bts: Fix DS area sharing with x86_pmu events Greg Kroah-Hartman
2015-06-27 1:09 ` [PATCH 4.1 05/11] perf/x86: Honor the architectural performance monitoring version Greg Kroah-Hartman
2015-06-27 1:09 ` [PATCH 4.1 06/11] perf tools: Fix build breakage if prefix= is specified Greg Kroah-Hartman
2015-06-27 1:09 ` [PATCH 4.1 07/11] Bluetooth: ath3k: Add support of 04ca:300d AR3012 device Greg Kroah-Hartman
2015-06-27 1:09 ` [PATCH 4.1 08/11] ath3k: Add support of 0489:e076 " Greg Kroah-Hartman
2015-06-27 1:09 ` [PATCH 4.1 09/11] ath3k: add support of 13d3:3474 " Greg Kroah-Hartman
2015-06-27 1:09 ` [PATCH 4.1 11/11] cdc-acm: Add support of ATOL FPrint fiscal printers Greg Kroah-Hartman
2015-06-27 3:13 ` [PATCH 4.1 00/11] 4.1.1-stable review Shuah Khan
2015-06-27 15:37 ` Greg Kroah-Hartman
2015-06-27 6:07 ` Guenter Roeck
2015-06-27 15:38 ` Greg Kroah-Hartman
2015-06-27 8:18 ` Sudip Mukherjee
2015-06-27 15:38 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150627010859.877151900@linuxfoundation.org \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=bp@suse.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matz@suse.de \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox