From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Tejun Heo <tj@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Lai Jiangshan <laijs@cn.fujitsu.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [GIT PULL] workqueue changes for v4.2-rc1
Date: Sat, 27 Jun 2015 09:21:09 -0700 [thread overview]
Message-ID: <20150627162056.GD3717@linux.vnet.ibm.com> (raw)
In-Reply-To: <20150627080928.GA4783@gmail.com>
On Sat, Jun 27, 2015 at 10:09:28AM +0200, Ingo Molnar wrote:
>
> * Linus Torvalds <torvalds@linux-foundation.org> wrote:
>
> > On Fri, Jun 26, 2015 at 9:01 AM, Tejun Heo <tj@kernel.org> wrote:
> > >
> > > Ooh, it isn't in mainline yet but pulling rcu tree will cause a silent
> > > conflict with this pull request which leads to build failure.
> >
> > I tend to try to do a full "make allmodconfig" build between all pull
> > requests (although I can optimize that a bit for very targeted pull
> > requests), so hopefully I'll notice and remember your note.
> >
> > But just in case:
> >
> > > The two colliding commits are.
> > >
> > > 5b95e1af8d17 ("workqueue: wq_pool_mutex protects the attrs-installation")
> > > eeacf8982637 ("rcu: Rename rcu_lockdep_assert() to RCU_LOCKDEP_WARN()")
> > >
> > > The former adds rcu_lockdep_assert() usage and the latter renames and flips
> > > it. It can be resolved by renaming and negating the conditions in the new
> > > usage.
> >
> > it would be great if when I get the RCU pull request that introduces that
> > renaming, whoever sends it to me could remind me about it.
> >
> > I'm assuming the pull request will come through Ingo. Ingo?
>
> Yeah.
>
> There was some discussion about how to warn about RCU failures precisely, so I
> think Paul yanked the new style RCU warnings for the time being. When/if they
> come back I'll be careful and will remind you of semantic conflicts.
Yes, it ended up in the batch destined for v4.3.
If it would make things easier, I could easily introduce the new API in
v4.3, along with the changes visible at that time, and pull the old API
in v4.4. That way, the conflicts appearing in v4.4 could be resolved
in the originating tree, given that the new API would then be in place
everywhere.
Either way works for me, just let me know!
Thanx, Paul
next prev parent reply other threads:[~2015-06-27 16:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-26 15:35 [GIT PULL] workqueue changes for v4.2-rc1 Tejun Heo
2015-06-26 16:01 ` Tejun Heo
2015-06-27 3:18 ` Linus Torvalds
2015-06-27 4:35 ` Stephen Rothwell
2015-06-27 16:16 ` Paul E. McKenney
2015-06-27 8:09 ` Ingo Molnar
2015-06-27 16:21 ` Paul E. McKenney [this message]
2015-06-29 6:52 ` Ingo Molnar
2015-06-29 20:51 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150627162056.GD3717@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=a.p.zijlstra@chello.nl \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox