* [PATCH] hwmon: (dell-smm-hwon) Use a valid name attribute
@ 2015-06-27 13:22 Gabriele Mazzotta
2015-06-27 14:39 ` Guenter Roeck
0 siblings, 1 reply; 3+ messages in thread
From: Gabriele Mazzotta @ 2015-06-27 13:22 UTC (permalink / raw)
To: pali.rohar, linux, jdelvare
Cc: gregkh, arnd, stevenhoneyman, Valdis.Kletnieks, jochen,
linux-kernel, lm-sensors, Gabriele Mazzotta
As per Documentation/hwmon/sysfs-interface, hwmon name attributes must
not include '-', so replace 'dell-smm' with 'dell_smm'.
Fixes: 039ae58503f3 ("hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k")
Signed-off-by: Gabriele Mazzotta <gabriele.mzt@gmail.com>
---
drivers/hwmon/dell-smm-hwmon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
index 2a80882..37c16af 100644
--- a/drivers/hwmon/dell-smm-hwmon.c
+++ b/drivers/hwmon/dell-smm-hwmon.c
@@ -777,7 +777,7 @@ static int __init i8k_init_hwmon(void)
if (err >= 0)
i8k_hwmon_flags |= I8K_HWMON_HAVE_FAN2;
- i8k_hwmon_dev = hwmon_device_register_with_groups(NULL, "dell-smm",
+ i8k_hwmon_dev = hwmon_device_register_with_groups(NULL, "dell_smm",
NULL, i8k_groups);
if (IS_ERR(i8k_hwmon_dev)) {
err = PTR_ERR(i8k_hwmon_dev);
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] hwmon: (dell-smm-hwon) Use a valid name attribute
2015-06-27 13:22 [PATCH] hwmon: (dell-smm-hwon) Use a valid name attribute Gabriele Mazzotta
@ 2015-06-27 14:39 ` Guenter Roeck
2015-06-27 16:21 ` Pali Rohár
0 siblings, 1 reply; 3+ messages in thread
From: Guenter Roeck @ 2015-06-27 14:39 UTC (permalink / raw)
To: Gabriele Mazzotta, pali.rohar, jdelvare
Cc: gregkh, arnd, stevenhoneyman, Valdis.Kletnieks, jochen,
linux-kernel, lm-sensors
On 06/27/2015 06:22 AM, Gabriele Mazzotta wrote:
> As per Documentation/hwmon/sysfs-interface, hwmon name attributes must
> not include '-', so replace 'dell-smm' with 'dell_smm'.
>
> Fixes: 039ae58503f3 ("hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k")
> Signed-off-by: Gabriele Mazzotta <gabriele.mzt@gmail.com>
Applied.
Pali, would be great if you can send me an Acked-by: before I send
the pull request to Linus.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] hwmon: (dell-smm-hwon) Use a valid name attribute
2015-06-27 14:39 ` Guenter Roeck
@ 2015-06-27 16:21 ` Pali Rohár
0 siblings, 0 replies; 3+ messages in thread
From: Pali Rohár @ 2015-06-27 16:21 UTC (permalink / raw)
To: Guenter Roeck
Cc: Gabriele Mazzotta, jdelvare, gregkh, arnd, stevenhoneyman,
Valdis.Kletnieks, jochen, linux-kernel, lm-sensors
[-- Attachment #1: Type: Text/Plain, Size: 660 bytes --]
On Saturday 27 June 2015 16:39:09 Guenter Roeck wrote:
> On 06/27/2015 06:22 AM, Gabriele Mazzotta wrote:
> > As per Documentation/hwmon/sysfs-interface, hwmon name attributes
> > must not include '-', so replace 'dell-smm' with 'dell_smm'.
> >
> > Fixes: 039ae58503f3 ("hwmon: Allow to compile dell-smm-hwmon driver
> > without /proc/i8k") Signed-off-by: Gabriele Mazzotta
> > <gabriele.mzt@gmail.com>
>
> Applied.
>
> Pali, would be great if you can send me an Acked-by: before I send
> the pull request to Linus.
>
> Thanks,
> Guenter
It's ok,
Acked-by: Pali Rohár <pali.rohar@gmail.com>
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-06-27 16:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-27 13:22 [PATCH] hwmon: (dell-smm-hwon) Use a valid name attribute Gabriele Mazzotta
2015-06-27 14:39 ` Guenter Roeck
2015-06-27 16:21 ` Pali Rohár
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox