* [PATCH]drivers:staging:visorbus:Fix checkpatch warnings
@ 2015-06-28 16:54 Ravi Teja
2015-06-29 3:18 ` Greg KH
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Ravi Teja @ 2015-06-28 16:54 UTC (permalink / raw)
To: benjamin.romer, david.kershner
Cc: gregkh, jes.sorensen, dzickus, sparmaintainer, devel,
linux-kernel
This patch fixes checkpatch warnings
Signed-off-by: Ravi Teja Darbha <ravi2j@gmail.com>
---
drivers/staging/unisys/visorbus/visorchipset.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/visorchipset.c
index bb8087e..62f7f68 100644
--- a/drivers/staging/unisys/visorbus/visorchipset.c
+++ b/drivers/staging/unisys/visorbus/visorchipset.c
@@ -1410,8 +1410,8 @@ visorchipset_chipset_ready(void)
static int
visorchipset_chipset_selftest(void)
{
- char env_selftest[20];
- char *envp[] = { env_selftest, NULL };
+ static char env_selftest[20];
+ static const char * const envp[] = { env_selftest, NULL };
sprintf(env_selftest, "SPARSP_SELFTEST=%d", 1);
kobject_uevent_env(&visorchipset_platform_device.dev.kobj, KOBJ_CHANGE,
@@ -1559,9 +1559,9 @@ static void
parahotplug_request_kickoff(struct parahotplug_request *req)
{
struct controlvm_message_packet *cmd = &req->msg.cmd;
- char env_cmd[40], env_id[40], env_state[40], env_bus[40], env_dev[40],
- env_func[40];
- char *envp[] = {
+ static char env_cmd[40], env_id[40], env_state[40], env_bus[40],
+ env_dev[40], env_func[40];
+ static const char * const envp[] = {
env_cmd, env_id, env_state, env_bus, env_dev, env_func, NULL
};
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH]drivers:staging:visorbus:Fix checkpatch warnings
2015-06-28 16:54 [PATCH]drivers:staging:visorbus:Fix checkpatch warnings Ravi Teja
@ 2015-06-29 3:18 ` Greg KH
2015-06-29 8:29 ` Dan Carpenter
2015-06-29 13:50 ` Don Zickus
2 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2015-06-29 3:18 UTC (permalink / raw)
To: Ravi Teja
Cc: benjamin.romer, david.kershner, gregkh, jes.sorensen, dzickus,
sparmaintainer, devel, linux-kernel
On Sun, Jun 28, 2015 at 10:24:49PM +0530, Ravi Teja wrote:
>
> This patch fixes checkpatch warnings
What warnings? Be specific please.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH]drivers:staging:visorbus:Fix checkpatch warnings
2015-06-28 16:54 [PATCH]drivers:staging:visorbus:Fix checkpatch warnings Ravi Teja
2015-06-29 3:18 ` Greg KH
@ 2015-06-29 8:29 ` Dan Carpenter
2015-06-29 13:50 ` Don Zickus
2 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2015-06-29 8:29 UTC (permalink / raw)
To: Ravi Teja
Cc: benjamin.romer, david.kershner, dzickus, devel, jes.sorensen,
sparmaintainer, linux-kernel, gregkh
On Sun, Jun 28, 2015 at 10:24:49PM +0530, Ravi Teja wrote:
>
> This patch fixes checkpatch warnings
>
This patch is scary for how wrong it looks. But the changelog is
definitely wrong so I'm not going to try understand the patch.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH]drivers:staging:visorbus:Fix checkpatch warnings
2015-06-28 16:54 [PATCH]drivers:staging:visorbus:Fix checkpatch warnings Ravi Teja
2015-06-29 3:18 ` Greg KH
2015-06-29 8:29 ` Dan Carpenter
@ 2015-06-29 13:50 ` Don Zickus
2 siblings, 0 replies; 4+ messages in thread
From: Don Zickus @ 2015-06-29 13:50 UTC (permalink / raw)
To: Ravi Teja
Cc: benjamin.romer, david.kershner, gregkh, jes.sorensen,
sparmaintainer, devel, linux-kernel
On Sun, Jun 28, 2015 at 10:24:49PM +0530, Ravi Teja wrote:
>
> This patch fixes checkpatch warnings
>
> Signed-off-by: Ravi Teja Darbha <ravi2j@gmail.com>
David,
Is this code removed after you ripped out the parahotplug stuff?
IOW, the next round of updates from Ben might obsolete this patch.
Cheers,
Don
> ---
> drivers/staging/unisys/visorbus/visorchipset.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/visorchipset.c
> index bb8087e..62f7f68 100644
> --- a/drivers/staging/unisys/visorbus/visorchipset.c
> +++ b/drivers/staging/unisys/visorbus/visorchipset.c
> @@ -1410,8 +1410,8 @@ visorchipset_chipset_ready(void)
> static int
> visorchipset_chipset_selftest(void)
> {
> - char env_selftest[20];
> - char *envp[] = { env_selftest, NULL };
> + static char env_selftest[20];
> + static const char * const envp[] = { env_selftest, NULL };
>
> sprintf(env_selftest, "SPARSP_SELFTEST=%d", 1);
> kobject_uevent_env(&visorchipset_platform_device.dev.kobj, KOBJ_CHANGE,
> @@ -1559,9 +1559,9 @@ static void
> parahotplug_request_kickoff(struct parahotplug_request *req)
> {
> struct controlvm_message_packet *cmd = &req->msg.cmd;
> - char env_cmd[40], env_id[40], env_state[40], env_bus[40], env_dev[40],
> - env_func[40];
> - char *envp[] = {
> + static char env_cmd[40], env_id[40], env_state[40], env_bus[40],
> + env_dev[40], env_func[40];
> + static const char * const envp[] = {
> env_cmd, env_id, env_state, env_bus, env_dev, env_func, NULL
> };
>
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-06-29 13:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-28 16:54 [PATCH]drivers:staging:visorbus:Fix checkpatch warnings Ravi Teja
2015-06-29 3:18 ` Greg KH
2015-06-29 8:29 ` Dan Carpenter
2015-06-29 13:50 ` Don Zickus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox