From: Borislav Petkov <bp@alien8.de>
To: Mike Galbraith <umgwanakikbuti@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>, Ingo Molnar <mingo@elte.hu>,
LKML <linux-kernel@vger.kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Andy Lutomirski <luto@kernel.org>,
Denys Vlasenko <dvlasenk@redhat.com>,
Oleg Nesterov <oleg@redhat.com>, Dave Hansen <dave@sr71.net>
Subject: Re: [all better] Re: regression: massive trouble with fpu rework
Date: Mon, 29 Jun 2015 10:33:02 +0200 [thread overview]
Message-ID: <20150629083302.GA13113@pd.tnic> (raw)
In-Reply-To: <1435566329.2900.1.camel@gmail.com>
On Mon, Jun 29, 2015 at 10:25:29AM +0200, Mike Galbraith wrote:
> On Mon, 2015-06-29 at 08:40 +0200, Ingo Molnar wrote:
> > *
> > Ok, so could you please move the fpu__init_system() further up and see which
> > position is that starts breaking with the BIOS option set?
> >
> > here's the current, broken layout of the code:
> >
> > get_cpu_cap(c);
> > [0] fpu__init_system(c);
> >
> > if (this_cpu->c_early_init)
> > this_cpu->c_early_init(c);
> [0] is the only spot that breaks box.
I bet it is that
/* Unmask CPUID levels if masked: */
if (c->x86 > 6 || (c->x86 == 6 && c->x86_model >= 0xd)) {
if (msr_clear_bit(MSR_IA32_MISC_ENABLE,
MSR_IA32_MISC_ENABLE_LIMIT_CPUID_BIT) > 0) {
c->cpuid_level = cpuid_eax(0);
get_cpu_cap(c);
}
}
in early_init_intel(). If you feel like playing, you might comment it
out to see what happens.
:-)
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
next prev parent reply other threads:[~2015-06-29 8:33 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-27 6:25 regression: massive trouble with fpu rework Mike Galbraith
2015-06-27 8:18 ` [all better] " Mike Galbraith
2015-06-27 8:25 ` Ingo Molnar
2015-06-27 8:55 ` Mike Galbraith
2015-06-27 9:37 ` Borislav Petkov
2015-06-27 11:01 ` Mike Galbraith
2015-06-27 21:02 ` Henrique de Moraes Holschuh
2015-06-28 3:11 ` Mike Galbraith
2015-06-28 15:06 ` Henrique de Moraes Holschuh
2015-06-28 15:39 ` Mike Galbraith
2015-06-29 1:12 ` Henrique de Moraes Holschuh
2015-06-29 6:40 ` Ingo Molnar
2015-06-29 8:25 ` Mike Galbraith
2015-06-29 8:33 ` Borislav Petkov [this message]
2015-06-29 8:41 ` Mike Galbraith
2015-06-29 9:35 ` Ingo Molnar
2015-06-29 9:57 ` Borislav Petkov
2015-06-29 19:48 ` H. Peter Anvin
2015-06-30 5:14 ` Ingo Molnar
2015-06-29 12:27 ` Mike Galbraith
2015-06-29 13:09 ` Borislav Petkov
2015-06-30 5:16 ` Ingo Molnar
2015-06-30 20:22 ` H. Peter Anvin
2015-07-09 13:13 ` Henrique de Moraes Holschuh
2015-06-29 19:50 ` H. Peter Anvin
2015-06-30 5:18 ` Ingo Molnar
2015-06-30 5:24 ` [tip:x86/urgent] x86/fpu: Fix FPU related boot regression when CPUID masking BIOS feature is enabled tip-bot for Ingo Molnar
2015-06-27 8:18 ` regression: massive trouble with fpu rework Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150629083302.GA13113@pd.tnic \
--to=bp@alien8.de \
--cc=dave@sr71.net \
--cc=dvlasenk@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=tglx@linutronix.de \
--cc=umgwanakikbuti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox