Re: [v4 01/16] KVM: Extend struct pi_desc for VT-d Posted-Interrupts

Paolo Bonzini
2015-06-23T15:50:04Z

On 11/06/2015 12:51, Feng Wu wrote:
> + union {
> + struct {
> + /* bit 256 - Outstanding Notification */
> + u64 on : 1,
> + /* bit 257 - Suppress Notification */
> + sn : 1,
> + /* bit 271:258 - Reserved */
> + rsvd_1 : 14,
> + /* bit 279:272 - Notification Vector */
> + nv : 8,
> + /* bit 287:280 - Reserved */
> + rsvd_2 : 8,
> + /* bit 319:288 - Notification Destination */
> + ndst : 32;

Please do not use bitfields, Linus doesn't like them. Use static
inlines instead to extract or set the fields from the control field.

Paolo

> + };
> + u64 control;
> + };
> + u32 rsvd[6];