From: Borislav Petkov <bp@alien8.de>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: "Luck, Tony" <tony.luck@intel.com>,
"Wang, Rui Y" <rui.y.wang@intel.com>,
Dave Airlie <airlied@redhat.com>,
"Clark, Rob" <robdclark@gmail.com>,
"Roper, Matthew D" <matthew.d.roper@intel.com>,
"Chen, Gong" <gong.chen@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: drm/mgag200: doesn't work in panic context
Date: Mon, 29 Jun 2015 11:42:16 +0200 [thread overview]
Message-ID: <20150629094215.GD12383@pd.tnic> (raw)
In-Reply-To: <CAKMK7uFuN1MP7=HW7VOTefnHLRsRYBh5i+pmdqug9sO6d5KXqA@mail.gmail.com>
On Mon, Jun 29, 2015 at 11:25:17AM +0200, Daniel Vetter wrote:
> As long as the display is up and running we should have a fair stab at
> showing the oops
Yeah, that has the same problem as all the other methods for showing
oops - *if* it is still healthly. Like, for example, trying to catch an
oops in networking with netconsole :)
> - it's just that no one has seriously bothered with the necessary
> infastructure, automated testing (it won't work otherwise) and driver
> work.
Right.
> drm_fb_helper_panic isn't the only panic handler - fbdev/fbcon have
> their own. They interfere, and fbdev blissfully assumes that it can
> call almost any driver hook from hardirq context. Which means you'd
> also need to consolidate the various hand-rolled (in drivers instead
> of the fbdev helper) bits to offload fbdev callbacks to workers and
> make sure we don't go boom in panics in there either.
Hmmm, this would mean to go and tell them through the panic notifier
to not do anything "risky" anymore. Perhaps even stop them from doing
regular tasks which could become risky in the case of panic. I guess
this would mean, we should be doing the same in other subsystems too.
Hmm.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
next prev parent reply other threads:[~2015-06-29 9:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-26 7:55 drm/mgag200: doesn't work in panic context Rui Wang
2015-06-26 9:27 ` Daniel Vetter
2015-06-26 18:30 ` Luck, Tony
2015-06-27 13:52 ` Daniel Vetter
2015-06-27 14:12 ` Borislav Petkov
2015-06-27 17:56 ` Daniel Vetter
2015-06-29 8:09 ` Borislav Petkov
2015-06-29 9:25 ` Daniel Vetter
2015-06-29 9:42 ` Borislav Petkov [this message]
2015-06-29 9:58 ` Daniel Vetter
-- strict thread matches above, loose matches on Subject: below --
2015-06-30 2:53 Rui Wang
2015-06-30 6:36 ` Daniel Vetter
2015-06-30 7:23 Rui Wang
2015-06-30 15:23 ` Daniel Vetter
2015-07-01 7:26 Rui Wang
2015-07-01 9:59 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150629094215.GD12383@pd.tnic \
--to=bp@alien8.de \
--cc=airlied@redhat.com \
--cc=daniel.vetter@ffwll.ch \
--cc=gong.chen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.d.roper@intel.com \
--cc=robdclark@gmail.com \
--cc=rui.y.wang@intel.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox