From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752880AbbF2Nuu (ORCPT ); Mon, 29 Jun 2015 09:50:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39921 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753297AbbF2Nun (ORCPT ); Mon, 29 Jun 2015 09:50:43 -0400 Date: Mon, 29 Jun 2015 09:50:40 -0400 From: Don Zickus To: Ravi Teja Cc: benjamin.romer@unisys.com, david.kershner@unisys.com, gregkh@linuxfoundation.com, jes.sorensen@redhat.com, sparmaintainer@unisys.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH]drivers:staging:visorbus:Fix checkpatch warnings Message-ID: <20150629135040.GW178524@redhat.com> References: <559026D9.3090704@ecolibriumenergy.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <559026D9.3090704@ecolibriumenergy.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 28, 2015 at 10:24:49PM +0530, Ravi Teja wrote: > > This patch fixes checkpatch warnings > > Signed-off-by: Ravi Teja Darbha David, Is this code removed after you ripped out the parahotplug stuff? IOW, the next round of updates from Ben might obsolete this patch. Cheers, Don > --- > drivers/staging/unisys/visorbus/visorchipset.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/visorchipset.c > index bb8087e..62f7f68 100644 > --- a/drivers/staging/unisys/visorbus/visorchipset.c > +++ b/drivers/staging/unisys/visorbus/visorchipset.c > @@ -1410,8 +1410,8 @@ visorchipset_chipset_ready(void) > static int > visorchipset_chipset_selftest(void) > { > - char env_selftest[20]; > - char *envp[] = { env_selftest, NULL }; > + static char env_selftest[20]; > + static const char * const envp[] = { env_selftest, NULL }; > > sprintf(env_selftest, "SPARSP_SELFTEST=%d", 1); > kobject_uevent_env(&visorchipset_platform_device.dev.kobj, KOBJ_CHANGE, > @@ -1559,9 +1559,9 @@ static void > parahotplug_request_kickoff(struct parahotplug_request *req) > { > struct controlvm_message_packet *cmd = &req->msg.cmd; > - char env_cmd[40], env_id[40], env_state[40], env_bus[40], env_dev[40], > - env_func[40]; > - char *envp[] = { > + static char env_cmd[40], env_id[40], env_state[40], env_bus[40], > + env_dev[40], env_func[40]; > + static const char * const envp[] = { > env_cmd, env_id, env_state, env_bus, env_dev, env_func, NULL > }; > > -- > 1.9.1 >