From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752814AbbF2P0j (ORCPT <rfc822;w@1wt.eu>);
	Mon, 29 Jun 2015 11:26:39 -0400
Received: from 8bytes.org ([81.169.241.247]:37322 "EHLO theia.8bytes.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750849AbbF2P0c (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 29 Jun 2015 11:26:32 -0400
Date: Mon, 29 Jun 2015 17:26:30 +0200
From: Joerg Roedel <joro@8bytes.org>
To: Michael Welling <mwelling@ieee.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jslaby@suse.cz>, linux-serial@vger.kernel.org,
        linux-kernel@vger.kernel.org, Joerg Roedel <jroedel@suse.de>,
        Peter Hurley <peter@hurleysoftware.com>,
        Joe Schultz <jschultz@xes-inc.com>
Subject: Re: [PATCH] serial: 8250: Do XR17V35X specific wakeup in
 serial8250_do_startup
Message-ID: <20150629152630.GL18569@8bytes.org>
References: <1434726737-2585-1-git-send-email-joro@8bytes.org>
 <20150619170910.GA6002@deathray>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150619170910.GA6002@deathray>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jun 19, 2015 at 12:09:10PM -0500, Michael Welling wrote:
> 
> Looks good to me. The datasheet indicates that bit 4 of the EFR needs to be set to access
> to IER [7:5], ISR [5:4], FCR[5:4], MCR[7:5], MSR.

Thanks! I updated the patch a little bit and wrote a better changelog
entry, mentioning the above bits. Will send a new version after the
merge window.


	Joerg