From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753445AbbF2TpJ (ORCPT ); Mon, 29 Jun 2015 15:45:09 -0400 Received: from mail-ie0-f174.google.com ([209.85.223.174]:34649 "EHLO mail-ie0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752114AbbF2TpA (ORCPT ); Mon, 29 Jun 2015 15:45:00 -0400 Date: Mon, 29 Jun 2015 12:44:54 -0700 From: Dmitry Torokhov To: duson Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org Subject: Re: [PATCH] Input: elan_i2c - Add hover event for ST format Message-ID: <20150629194454.GE22166@dtor-ws> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Duson, On Mon, Jun 29, 2015 at 09:19:09AM +0800, duson wrote: > Signed-off by: Duson Lin > --- > drivers/input/mouse/elan_i2c_core.c | 2 ++ I'd rather we teach input_mt_init_slots() and input_mt_report_pointer_emulation() do that for us. Thanks. > 1 file changed, 2 insertions(+) > > diff --git a/drivers/input/mouse/elan_i2c_core.c b/drivers/input/mouse/elan_i2c_core.c > index 62641f2..ce97e28 100644 > --- a/drivers/input/mouse/elan_i2c_core.c > +++ b/drivers/input/mouse/elan_i2c_core.c > @@ -847,6 +847,7 @@ static void elan_report_absolute(struct elan_tp_data *data, u8 *packet) > } > > input_report_key(input, BTN_LEFT, tp_info & 0x01); > + input_report_abs(input, ABS_DISTANCE, hover_event != 0); > input_mt_report_pointer_emulation(input, true); > input_sync(input); > } > @@ -922,6 +923,7 @@ static int elan_setup_input_device(struct elan_tp_data *data) > input_abs_set_res(input, ABS_Y, data->y_res); > input_set_abs_params(input, ABS_PRESSURE, 0, ETP_MAX_PRESSURE, 0, 0); > input_set_abs_params(input, ABS_TOOL_WIDTH, 0, ETP_FINGER_WIDTH, 0, 0); > + input_set_abs_params(input, ABS_DISTANCE, 0, 1, 0, 0); > > /* And MT parameters */ > input_set_abs_params(input, ABS_MT_POSITION_X, 0, data->max_x, 0, 0); > > > > -- Dmitry