* Re: [PATCH 3/3] x86_64: kasan: add message about kasan being initialized [not found] ` <20150620131813.GA6534@gmail.com> @ 2015-06-22 16:06 ` Andrey Ryabinin 2015-06-30 5:23 ` Ingo Molnar 0 siblings, 1 reply; 2+ messages in thread From: Andrey Ryabinin @ 2015-06-22 16:06 UTC (permalink / raw) To: Ingo Molnar, Dmitry Vyukov Cc: Ingo Molnar, H. Peter Anvin, Thomas Gleixner, x86@kernel.org, Andrey Konovalov, Andrew Morton, Borislav Petkov, Alexander Popov, Alexander Potapenko, open list On 06/20/2015 04:18 PM, Ingo Molnar wrote: > > Please call it 'kasan' or 'KASAN', and also explain it in the message and prefix > it properly with the subsystem name (kasan), so something like: > > pr_info("kasan: Kernel Address SANitizer (KASAN) initialized\n"); > > Other kasan messages should also carry a 'kasan: ' prefix, so that it's > unambiguous what generated the message, and also to make it easier to grep out of > logs. > This patch adds "kasan: " prefix for all messages from this file ( +#define pr_fmt(fmt) "kasan: " fmt ) I'm agree with Dmitry, I would choose kasan name too. In this case, adding explanation in the message will produce too much kasans in one short message: kasan: Kernel address sanitizer (kasan) initialized Perhaps it would be better to keep this patch as is. Ok? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/ ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 3/3] x86_64: kasan: add message about kasan being initialized 2015-06-22 16:06 ` [PATCH 3/3] x86_64: kasan: add message about kasan being initialized Andrey Ryabinin @ 2015-06-30 5:23 ` Ingo Molnar 0 siblings, 0 replies; 2+ messages in thread From: Ingo Molnar @ 2015-06-30 5:23 UTC (permalink / raw) To: Andrey Ryabinin Cc: Dmitry Vyukov, Ingo Molnar, H. Peter Anvin, Thomas Gleixner, x86@kernel.org, Andrey Konovalov, Andrew Morton, Borislav Petkov, Alexander Popov, Alexander Potapenko, open list * Andrey Ryabinin <a.ryabinin@samsung.com> wrote: > On 06/20/2015 04:18 PM, Ingo Molnar wrote: > > > > Please call it 'kasan' or 'KASAN', and also explain it in the message and prefix > > it properly with the subsystem name (kasan), so something like: > > > > pr_info("kasan: Kernel Address SANitizer (KASAN) initialized\n"); > > > > Other kasan messages should also carry a 'kasan: ' prefix, so that it's > > unambiguous what generated the message, and also to make it easier to grep out of > > logs. > > > > This patch adds "kasan: " prefix for all messages from this file ( +#define pr_fmt(fmt) "kasan: " fmt ) > > I'm agree with Dmitry, I would choose kasan name too. > In this case, adding explanation in the message will produce too much kasans in one short message: > > kasan: Kernel address sanitizer (kasan) initialized > > Perhaps it would be better to keep this patch as is. Ok? So if there's a latest series of fixes to apply, please send it. Thanks, Ingo ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-06-30 5:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1434734247-29153-1-git-send-email-a.ryabinin@samsung.com>
[not found] ` <1434734247-29153-3-git-send-email-a.ryabinin@samsung.com>
[not found] ` <CACT4Y+ZRJk+6QHGhN3Vz=Hnv=PjB2P-P-Y9UiZAHNsvO=7v_MA@mail.gmail.com>
[not found] ` <20150620131813.GA6534@gmail.com>
2015-06-22 16:06 ` [PATCH 3/3] x86_64: kasan: add message about kasan being initialized Andrey Ryabinin
2015-06-30 5:23 ` Ingo Molnar
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox