From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
Cc: bsingharora@gmail.com, mingo@kernel.org,
linux-kernel@vger.kernel.org, ricklind@us.ibm.com,
a.p.zijlstra@chello.nl
Subject: Re: [PATCH v2 2/2] schedstat: Expose /proc/pid/schedstat if CONFIG_SCHED_INFO is set
Date: Tue, 30 Jun 2015 11:25:37 +0530 [thread overview]
Message-ID: <20150630055537.GA21513@linux.vnet.ibm.com> (raw)
In-Reply-To: <0ccc1c22699b73679cf13527c5d80b807a988859.1435255405.git.naveen.n.rao@linux.vnet.ibm.com>
* Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com> [2015-06-25 23:53:38]:
> /*
> * Provides /proc/PID/schedstat
> */
> static int proc_pid_schedstat(struct seq_file *m, struct pid_namespace *ns,
> struct pid *pid, struct task_struct *task)
> {
> - seq_printf(m, "%llu %llu %lu\n",
> + if (unlikely(!sched_info_on()))
> + seq_printf(m, "0 0 0\n");
> + else
> + seq_printf(m, "%llu %lld %ld\n",
Should the above be seq_printf(m, "%llu %llu %lu\n", ?
> (unsigned long long)task->se.sum_exec_runtime,
> (unsigned long long)task->sched_info.run_delay,
> task->sched_info.pcount);
> --
> 2.4.0
>
--
Thanks and Regards
Srikar Dronamraju
next prev parent reply other threads:[~2015-06-30 5:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-25 18:23 [PATCH v2 0/2] Clean up schedstat and task delay acct config options Naveen N. Rao
2015-06-25 18:23 ` [PATCH v2 1/2] schedstat: Simplify sched_info accounting dependency Naveen N. Rao
2015-06-30 13:30 ` Srikar Dronamraju
2015-06-30 13:33 ` Balbir Singh
2015-07-03 7:45 ` [tip:sched/urgent] sched/stat: Simplify the " tip-bot for Naveen N. Rao
2015-07-04 8:07 ` tip-bot for Naveen N. Rao
2015-06-25 18:23 ` [PATCH v2 2/2] schedstat: Expose /proc/pid/schedstat if CONFIG_SCHED_INFO is set Naveen N. Rao
2015-06-30 5:55 ` Srikar Dronamraju [this message]
2015-06-30 6:16 ` Naveen N. Rao
2015-06-30 9:06 ` [PATCH v3 " Naveen N. Rao
2015-06-30 13:29 ` Srikar Dronamraju
2015-06-30 13:32 ` Balbir Singh
2015-07-03 7:46 ` [tip:sched/urgent] sched/stat: Expose /proc/pid/ schedstat if CONFIG_SCHED_INFO=y tip-bot for Naveen N. Rao
2015-07-04 8:07 ` tip-bot for Naveen N. Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150630055537.GA21513@linux.vnet.ibm.com \
--to=srikar@linux.vnet.ibm.com \
--cc=a.p.zijlstra@chello.nl \
--cc=bsingharora@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=ricklind@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox