From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753880AbbF3F4x (ORCPT ); Tue, 30 Jun 2015 01:56:53 -0400 Received: from e23smtp08.au.ibm.com ([202.81.31.141]:42150 "EHLO e23smtp08.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753671AbbF3F4m (ORCPT ); Tue, 30 Jun 2015 01:56:42 -0400 X-Helo: d23dlp03.au.ibm.com X-MailFrom: srikar@linux.vnet.ibm.com X-RcptTo: linux-kernel@vger.kernel.org Date: Tue, 30 Jun 2015 11:25:37 +0530 From: Srikar Dronamraju To: "Naveen N. Rao" Cc: bsingharora@gmail.com, mingo@kernel.org, linux-kernel@vger.kernel.org, ricklind@us.ibm.com, a.p.zijlstra@chello.nl Subject: Re: [PATCH v2 2/2] schedstat: Expose /proc/pid/schedstat if CONFIG_SCHED_INFO is set Message-ID: <20150630055537.GA21513@linux.vnet.ibm.com> Reply-To: Srikar Dronamraju References: <0ccc1c22699b73679cf13527c5d80b807a988859.1435255405.git.naveen.n.rao@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <0ccc1c22699b73679cf13527c5d80b807a988859.1435255405.git.naveen.n.rao@linux.vnet.ibm.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15063005-0029-0000-0000-000001C172E9 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Naveen N. Rao [2015-06-25 23:53:38]: > /* > * Provides /proc/PID/schedstat > */ > static int proc_pid_schedstat(struct seq_file *m, struct pid_namespace *ns, > struct pid *pid, struct task_struct *task) > { > - seq_printf(m, "%llu %llu %lu\n", > + if (unlikely(!sched_info_on())) > + seq_printf(m, "0 0 0\n"); > + else > + seq_printf(m, "%llu %lld %ld\n", Should the above be seq_printf(m, "%llu %llu %lu\n", ? > (unsigned long long)task->se.sum_exec_runtime, > (unsigned long long)task->sched_info.run_delay, > task->sched_info.pcount); > -- > 2.4.0 > -- Thanks and Regards Srikar Dronamraju