Re: [PATCH 1/3] platform/chrome: Don't make CHROME_PLATFORMS depends on X86 || ARM

Geert Uytterhoeven
2015-08-17T07:56:58Z

On Thu, Jun 25, 2015 at 2:20 AM, Javier Martinez Canillas
<javier.martinez@collabora.co.uk> wrote:
> The Chrome platform support depends on X86 || ARM because there are
> only Chromebooks using those architectures. But only some drivers
> depend on a given architecture, and the ones that do already have
> a dependency on their specific Kconfig symbol entries.
>
> An option is to also make CHROME_PLATFORMS depends on || COMPILE_TEST
> but is more future proof to remove the dependency and let the drivers
> be built in all architectures if possible to have more build coverage.
>
> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>

NAKed-by: Geert Uytterhoeven <geert@linux-m68k.org>

The proper way to have more build coverage is to extend the dependencies
with "|| COMPILE_TEST".

Yes I know MFD_CROS_EC selects CHROME_PLATFORMS, causing a
Kconfig warning on !X86 and !ARM.

Mixing "select" and "depends" (all other ChromeOS stuff depends on the
symbol) is bad practice, as it may lead to circular Kconfig dependencies.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds