4.2-rc0: akcipher breaks compilation

4.2-rc0: akcipher breaks compilation

[Pavel Machek]

Hi!

CC      crypto/akcipher.o
    CC      block/bio.o
    crypto/akcipher.c: In function ‘crypto_akcipher_report’:
    crypto/akcipher.c:30:32: error: storage size of ‘rakcipher’ isn’t
    known
      struct crypto_report_akcipher rakcipher;
                                      ^
				      crypto/akcipher.c:34:19: error:
    ‘CRYPTOCFGA_REPORT_AKCIPHER’ undeclared (first use in this
    function)
      if (nla_put(skb, CRYPTOCFGA_REPORT_AKCIPHER,
                         ^
			 crypto/akcipher.c:34:19: note: each
    undeclared identifier is reported only once for each function it
    appears in
    crypto/akcipher.c:35:14: error: invalid application of ‘sizeof’ to
    incomplete type ‘struct crypto_report_akcipher’
           sizeof(struct crypto_report_akcipher), &rakcipher))
	                 ^
			 crypto/akcipher.c:30:32: warning: unused
    variable ‘rakcipher’ [-Wunused-variable]
      struct crypto_report_akcipher rakcipher;
                                      ^
				      scripts/Makefile.build:258:
    recipe for target 'crypto/akcipher.o' failed
    make[1]: *** [crypto/akcipher.o] Error 1
    Makefile:945: recipe for target 'crypto' failed
    make: *** [crypto] Error 2
    make: *** Waiting for unfinished jobs....

Plus... it is not easy to disable akcipher due to "interesting"
Kconfig with select maze...
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: 4.2-rc0: akcipher breaks compilation

[Herbert Xu]

On Tue, Jun 30, 2015 at 11:27:50AM +0200, Pavel Machek wrote:
> Hi!
> 
> CC      crypto/akcipher.o
>     CC      block/bio.o
>     crypto/akcipher.c: In function ‘crypto_akcipher_report’:
>     crypto/akcipher.c:30:32: error: storage size of ‘rakcipher’ isn’t
>     known
>       struct crypto_report_akcipher rakcipher;
>                                       ^
> 				      crypto/akcipher.c:34:19: error:
>     ‘CRYPTOCFGA_REPORT_AKCIPHER’ undeclared (first use in this
>     function)
>       if (nla_put(skb, CRYPTOCFGA_REPORT_AKCIPHER,
>                          ^
> 			 crypto/akcipher.c:34:19: note: each
>     undeclared identifier is reported only once for each function it
>     appears in
>     crypto/akcipher.c:35:14: error: invalid application of ‘sizeof’ to
>     incomplete type ‘struct crypto_report_akcipher’
>            sizeof(struct crypto_report_akcipher), &rakcipher))
> 	                 ^
> 			 crypto/akcipher.c:30:32: warning: unused
>     variable ‘rakcipher’ [-Wunused-variable]
>       struct crypto_report_akcipher rakcipher;
>                                       ^
> 				      scripts/Makefile.build:258:
>     recipe for target 'crypto/akcipher.o' failed
>     make[1]: *** [crypto/akcipher.o] Error 1
>     Makefile:945: recipe for target 'crypto' failed
>     make: *** [crypto] Error 2
>     make: *** Waiting for unfinished jobs....

That's weird.  both symbols are meant to be defined in
include/uapi/linux/cryptouser.h.  Do you have that file and is
it up-to-date? Do you happen to have an obsolete
include/linux/cryptouser.h file in your tree?

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: 4.2-rc0: akcipher breaks compilation

[Pavel Machek]

On Tue 2015-06-30 22:48:26, Herbert Xu wrote:
> On Tue, Jun 30, 2015 at 11:27:50AM +0200, Pavel Machek wrote:
> > Hi!
> > 
> > CC      crypto/akcipher.o
> >     CC      block/bio.o
> >     crypto/akcipher.c: In function ‘crypto_akcipher_report’:
> >     crypto/akcipher.c:30:32: error: storage size of ‘rakcipher’ isn’t
> >     known
> >       struct crypto_report_akcipher rakcipher;
> >                                       ^
> > 				      crypto/akcipher.c:34:19: error:
> >     ‘CRYPTOCFGA_REPORT_AKCIPHER’ undeclared (first use in this
> >     function)
> >       if (nla_put(skb, CRYPTOCFGA_REPORT_AKCIPHER,
> >                          ^
> > 			 crypto/akcipher.c:34:19: note: each
> >     undeclared identifier is reported only once for each function it
> >     appears in
> >     crypto/akcipher.c:35:14: error: invalid application of ‘sizeof’ to
> >     incomplete type ‘struct crypto_report_akcipher’
> >            sizeof(struct crypto_report_akcipher), &rakcipher))
> > 	                 ^
> > 			 crypto/akcipher.c:30:32: warning: unused
> >     variable ‘rakcipher’ [-Wunused-variable]
> >       struct crypto_report_akcipher rakcipher;
> >                                       ^
> > 				      scripts/Makefile.build:258:
> >     recipe for target 'crypto/akcipher.o' failed
> >     make[1]: *** [crypto/akcipher.o] Error 1
> >     Makefile:945: recipe for target 'crypto' failed
> >     make: *** [crypto] Error 2
> >     make: *** Waiting for unfinished jobs....
> 
> That's weird.  both symbols are meant to be defined in
> include/uapi/linux/cryptouser.h.  Do you have that file and is
> it up-to-date? Do you happen to have an obsolete
> include/linux/cryptouser.h file in your tree?

I had the file, but probably had other copy of cryptouser.h somewhere.

git --work-tree=/data/l/linux-64 clean -df

helped. Thanks and sorry for the noise,
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html